From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES/RFC manager 00/14] split up content view into a view for each type
Date: Wed, 2 Sep 2020 13:03:23 +0200 [thread overview]
Message-ID: <20200902110337.25004-1-f.ebner@proxmox.com> (raw)
The goal of doing this is to have more flexibility/cleaner code for
content-type-dependent features in the content view. Now only buttons
that are useful for each content type are displayed. And it might make
sense to display different columns for different content types, e.g.
'parent' for cloned VM/CT images. The mechanism introduced in this series
(patch #13) is not used yet, suggestions for which columns to use for
which types are welcome.
API calls might be faster if only one type of content is requested.
The obvious drawback is that there is no view with all contents anymore.
The last patch is not directly related, but introduces the prune window
for backups, essentially copied over from the PBS code.
@Thomas: Hope this is not too far from what you had in mind.
Of course I can rebase the prune window patch on current master if prefer.
Fabian Ebner (14):
config panel: allow new nodes to be added later
storage panel/browser: use insertNodes function
use separate view for each content type
remove the now unneccessary grouping
content view: allow specifying title bar elements for init
turn nodename,storage,sm into object variables
add upload button conditionally
create and use TemplateView
create and use BackupView
get rid of unneccessary enableFn's
create ImageView and use it for VM and CT images
simplify reload call
content view: allow specifying which columns to show on init
backup view: add prune window
www/manager6/Makefile | 4 +
www/manager6/panel/ConfigPanel.js | 93 ++---
www/manager6/storage/BackupView.js | 96 ++++++
www/manager6/storage/Browser.js | 89 ++++-
www/manager6/storage/ContentView.js | 497 +++++----------------------
www/manager6/storage/ImageView.js | 74 ++++
www/manager6/storage/TemplateView.js | 212 ++++++++++++
www/manager6/window/Prune.js | 230 +++++++++++++
8 files changed, 836 insertions(+), 459 deletions(-)
create mode 100644 www/manager6/storage/BackupView.js
create mode 100644 www/manager6/storage/ImageView.js
create mode 100644 www/manager6/storage/TemplateView.js
create mode 100644 www/manager6/window/Prune.js
--
2.20.1
next reply other threads:[~2020-09-02 11:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 11:03 Fabian Ebner [this message]
2020-09-02 11:03 ` [pve-devel] [PATCH manager 01/14] config panel: allow new nodes to be added later Fabian Ebner
2020-09-02 11:03 ` [pve-devel] [PATCH manager 02/14] storage panel/browser: use insertNodes function Fabian Ebner
2020-09-02 11:03 ` [pve-devel] [PATCH manager 03/14] use separate view for each content type Fabian Ebner
2020-09-02 11:03 ` [pve-devel] [PATCH manager 04/14] remove the now unneccessary grouping Fabian Ebner
2020-09-02 11:03 ` [pve-devel] [PATCH manager 05/14] content view: allow specifying title bar elements for init Fabian Ebner
2020-09-02 11:03 ` [pve-devel] [PATCH manager 06/14] turn nodename, storage, sm into object variables Fabian Ebner
2020-09-02 11:03 ` [pve-devel] [PATCH manager 07/14] add upload button conditionally Fabian Ebner
2020-09-02 11:03 ` [pve-devel] [PATCH manager 08/14] create and use template view Fabian Ebner
2020-09-02 11:03 ` [pve-devel] [PATCH manager 09/14] create and use backup view Fabian Ebner
2020-09-02 11:03 ` [pve-devel] [PATCH manager 10/14] get rid of unneccessary enableFns Fabian Ebner
2020-09-02 11:03 ` [pve-devel] [PATCH manager 11/14] create ImageView and use it for VM and CT images Fabian Ebner
2020-09-02 11:03 ` [pve-devel] [PATCH manager 12/14] simplify reload call Fabian Ebner
2020-09-02 11:03 ` [pve-devel] [RFC manager 13/14] content view: allow specifying which columns to show on init Fabian Ebner
2020-09-02 11:03 ` [pve-devel] [PATCH manager 14/14] backup view: add prune window Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902110337.25004-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox