From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH common 0/2] adapt PVE::Tools::sendmail to match rust-implementation
Date: Tue, 1 Sep 2020 11:18:02 +0200 [thread overview]
Message-ID: <20200901091804.23647-1-s.ivanov@proxmox.com> (raw)
The 2 patches adapt PVE::Tools::sendmail to closely match the recently merged
implementation in our rust repository - see [0].
I moved the email regex from JSONSchema to Tools to reuse it for the sendmail
function (and eliminate one of the few email-address regexes in our codebase).
I did not add a dependency on libtimedate-perl (where Date::Format is), since
we already use Date::Parse in PVE::Certificate, without explicit dependency,
and it gets pulled in via libwww-perl -> libhttp-date-perl -> libtimedate-perl.
Glad to send an update for the dependency of course.
[0] https://lists.proxmox.com/pipermail/pbs-devel/2020-August/000423.html
Stoiko Ivanov (2):
move email regex from JSONSchema to Tools
sendmail-helper: only send multipart if necessary
src/PVE/JSONSchema.pm | 4 ++--
src/PVE/Tools.pm | 49 +++++++++++++++++++++++++++++--------------
2 files changed, 35 insertions(+), 18 deletions(-)
--
2.20.1
next reply other threads:[~2020-09-01 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 9:18 Stoiko Ivanov [this message]
2020-09-01 9:18 ` [pve-devel] [PATCH common 1/2] move email regex from JSONSchema to Tools Stoiko Ivanov
2020-09-01 9:18 ` [pve-devel] [PATCH common 2/2] sendmail-helper: only send multipart if necessary Stoiko Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901091804.23647-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox