From: "Dominic Jäger" <d.jaeger@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH series 0/4] Add GUI for disk reassignment
Date: Mon, 31 Aug 2020 13:04:48 +0200 [thread overview]
Message-ID: <20200831110448.GC120313@mala.proxmox.com> (raw)
In-Reply-To: <20200825151426.17428-1-a.lauterer@proxmox.com>
I reassigned some disks and it seemed to work nice for me :)
Error messages about unavailable disks for running VMs and equal source and
target VM made sense to me, correct possible targets were displayed, multiple
storages worked.
One thing that came to my mind: It might make sense to display what name the
reassigned disk got in the target VM in the log.
For example "Reassigned to VM 123 as Unused Disk 7 [maybe with volid]".
Because if there are multiple unused disks on the target VM it could happen
that it's not the one with the highest number?
On Tue, Aug 25, 2020 at 05:14:22PM +0200, Aaron Lauterer wrote:
> This patch series adds the GUI to the recent patch series [0] which
> enables the reassignment of disks between VMs.
>
> For this to work, the previous patch series [0] needs to be applied and
> installed.
next prev parent reply other threads:[~2020-08-31 11:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 15:14 Aaron Lauterer
2020-08-25 15:14 ` [pve-devel] [PATCH widget-toolkit 1/4] window/edit: add option to disable reset button Aaron Lauterer
2020-08-25 15:14 ` [pve-devel] [PATCH manager 2/4] ui: qemu/HardwareView: white space fixes Aaron Lauterer
2020-08-25 15:14 ` [pve-devel] [PATCH manager 3/4] ui: utils: add method to get VM data from resource store Aaron Lauterer
2020-08-31 10:51 ` Dominic Jäger
2020-08-25 15:14 ` [pve-devel] [PATCH manager 4/4] ui: qemu: Add disk reassign dialog Aaron Lauterer
2020-08-31 10:55 ` Dominic Jäger
2020-08-31 11:04 ` Dominic Jäger [this message]
2020-08-31 11:21 ` [pve-devel] [PATCH series 0/4] Add GUI for disk reassignment Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831110448.GC120313@mala.proxmox.com \
--to=d.jaeger@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox