public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH docs] pve-network.adoc: add spaces to separate links on newlines
@ 2020-08-31  9:23 Oguz Bektas
  2020-08-31 10:07 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Oguz Bektas @ 2020-08-31  9:23 UTC (permalink / raw)
  To: pve-devel

otherwise they all show up in one line on the wiki

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 pve-network.adoc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/pve-network.adoc b/pve-network.adoc
index 1c5ae17..294c201 100644
--- a/pve-network.adoc
+++ b/pve-network.adoc
@@ -261,8 +261,11 @@ post-down iptables -t raw -D PREROUTING -i fwbr+ -j CT --zone 1
 ----
 
 For more information about this, refer to the following links:
+
 https://commons.wikimedia.org/wiki/File:Netfilter-packet-flow.svg[Netfilter Packet Flow]
+
 https://lwn.net/Articles/370152/[Patch on netdev-list introducing conntrack zones]
+
 https://blog.lobraun.de/2019/05/19/prox/[Blog post with a good explanation by using TRACE in the raw table]
 
 
-- 
2.20.1




^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH docs] pve-network.adoc: add spaces to separate links on newlines
  2020-08-31  9:23 [pve-devel] [PATCH docs] pve-network.adoc: add spaces to separate links on newlines Oguz Bektas
@ 2020-08-31 10:07 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-08-31 10:07 UTC (permalink / raw)
  To: Proxmox VE development discussion, Oguz Bektas

On 31.08.20 11:23, Oguz Bektas wrote:
> otherwise they all show up in one line on the wiki
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  pve-network.adoc | 3 +++
>  1 file changed, 3 insertions(+)
> 
>

OK, but I do not want things like "pve-network.adoc" as commit subject tag, this
is for humans to get the context (rough category) of what the patch affects, if
I want to know the affected files in git log I just use the "--stat" flag, the patch
mail has it already anyway.

I changed it to:
> network: nat: add extra newlines between links for readability

and clarified that this affected all rendere outputs, i.e., also pdf and html.

applied, thanks!





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-31 10:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-31  9:23 [pve-devel] [PATCH docs] pve-network.adoc: add spaces to separate links on newlines Oguz Bektas
2020-08-31 10:07 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal