From: Alexandre Derumier <aderumier@odiso.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v6 pve-network 07/18] subnet: fix on_delete_hook
Date: Tue, 25 Aug 2020 07:02:11 +0200 [thread overview]
Message-ID: <20200825050222.12447-8-aderumier@odiso.com> (raw)
In-Reply-To: <20200825050222.12447-1-aderumier@odiso.com>
---
PVE/Network/SDN/SubnetPlugin.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/PVE/Network/SDN/SubnetPlugin.pm b/PVE/Network/SDN/SubnetPlugin.pm
index c555314..ea47684 100644
--- a/PVE/Network/SDN/SubnetPlugin.pm
+++ b/PVE/Network/SDN/SubnetPlugin.pm
@@ -116,12 +116,12 @@ sub on_delete_hook {
my ($class, $subnetid, $subnet_cfg, $vnet_cfg) = @_;
#verify if vnets have subnet
- foreach my $id (keys %{$vnet_cfg->{ids}}) {
- my $vnet = $vnet_cfg->{ids}->{$id};
+ foreach my $vnetid (keys %{$vnet_cfg->{ids}}) {
+ my $vnet = $vnet_cfg->{ids}->{$vnetid};
my @subnets = PVE::Tools::split_list($vnet->{subnets}) if $vnet->{subnets};
foreach my $subnet (@subnets) {
my $id = $subnet =~ s/\//-/r;
- raise_param_exc({ subnet => "$subnet is attached to vnet $id"}) if $id eq $subnetid;
+ raise_param_exc({ subnet => "$subnet is attached to vnet $vnetid"}) if $id eq $subnetid;
}
}
--
2.20.1
next prev parent reply other threads:[~2020-08-25 5:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 5:02 [pve-devel] [PATCH v6 pve-network 00/18] sdn : add subnets management Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 01/18] add subnet plugin Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 02/18] vnets: add subnets Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 03/18] add subnets verifications hooks Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 04/18] zones: simple|evpn: add gateway ip from subnets to vnet Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 05/18] zone: add vnet_update_hook Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 06/18] vnets: subnets: use cidr Alexandre Derumier
2020-08-25 5:02 ` Alexandre Derumier [this message]
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 08/18] api2: subnet create: convert cidr to subnetid Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 09/18] api2: increase version on apply/reload only Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 10/18] add ipams plugins Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 11/18] add pve internal ipam plugin Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 12/18] vnets: find_free_ip : add ipversion detection Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 13/18] vnets: add add_ip Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 14/18] vnets: add del_ip + rework add_ip/find_free_ip Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 15/18] add dns plugin Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 16/18] Fix vnet gateway for routed setup + /32 pointopoint subnet Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 17/18] ipam : pveplugin : fix find_next_free_ip Alexandre Derumier
2020-08-25 5:02 ` [pve-devel] [PATCH v6 pve-network 18/18] add vnet to subnets && remove subnetlist from vnet Alexandre Derumier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825050222.12447-8-aderumier@odiso.com \
--to=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox