public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [pve-manager: Bump maximum number of container net interfaces from 10 to 32 0/1]
@ 2020-08-23 11:38 Stephan Leemburg
  2020-08-23 11:38 ` [pve-devel] [Bump maximum number of container net interfaces from 10 to 32 1/1] Bump maximum number of container net interfaces from 10 to 32 Stephan Leemburg
  0 siblings, 1 reply; 4+ messages in thread
From: Stephan Leemburg @ 2020-08-23 11:38 UTC (permalink / raw)
  To: pve-devel; +Cc: Stephan Leemburg


Bump maximum number of container net interfaces from 10 to 32

For some environments firewalls with more than 10 interfaces are required.
With KVM (qm) this can be achieved, but with LXC (pct) not yet. As lxc is
much more lightweight than kvm, there can be a preference for using that.

This patch enables containers to have up to 32 interfaces.

Stephan Leemburg (1):
  Bump maximum number of container net interfaces from 10 to 32

 www/manager6/lxc/Network.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.25.1




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [Bump maximum number of container net interfaces from 10 to 32 1/1] Bump maximum number of container net interfaces from 10 to 32
  2020-08-23 11:38 [pve-devel] [pve-manager: Bump maximum number of container net interfaces from 10 to 32 0/1] Stephan Leemburg
@ 2020-08-23 11:38 ` Stephan Leemburg
  2020-08-27 10:58   ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 4+ messages in thread
From: Stephan Leemburg @ 2020-08-23 11:38 UTC (permalink / raw)
  To: pve-devel; +Cc: Stephan Leemburg

Signed-off-by: Stephan Leemburg <stephan.leemburg@it-functions.nl>
---
 www/manager6/lxc/Network.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/lxc/Network.js b/www/manager6/lxc/Network.js
index 2938c503..8af00fca 100644
--- a/www/manager6/lxc/Network.js
+++ b/www/manager6/lxc/Network.js
@@ -74,7 +74,7 @@ Ext.define('PVE.lxc.NetworkInputPanel', {
 	}
 
 	var i;
-	for (i = 0; i < 10; i++) {
+	for (i = 0; i < 32; i++) {
 	    if (me.isCreate && !me.dataCache['net'+i.toString()]) {
 		me.ifname = 'net' + i.toString();
 		break;
@@ -370,7 +370,7 @@ Ext.define('PVE.lxc.NetworkView', {
 		    records.push(net);
 		});
 		me.store.loadData(records);
-		me.down('button[name=addButton]').setDisabled((records.length >= 10));
+		me.down('button[name=addButton]').setDisabled((records.length >= 32));
 	    }
 	});
     },
-- 
2.25.1




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] applied: [Bump maximum number of container net interfaces from 10 to 32 1/1] Bump maximum number of container net interfaces from 10 to 32
  2020-08-23 11:38 ` [pve-devel] [Bump maximum number of container net interfaces from 10 to 32 1/1] Bump maximum number of container net interfaces from 10 to 32 Stephan Leemburg
@ 2020-08-27 10:58   ` Thomas Lamprecht
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2020-08-27 10:58 UTC (permalink / raw)
  To: Proxmox VE development discussion, Stephan Leemburg

Am 8/23/20 um 1:38 PM schrieb Stephan Leemburg:
> Signed-off-by: Stephan Leemburg <stephan.leemburg@it-functions.nl>
> ---
>  www/manager6/lxc/Network.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 


applied, thanks!




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [Bump maximum number of container net interfaces from 10 to 32 1/1] Bump maximum number of container net interfaces from 10 to 32
  2020-08-23 11:38 [pve-devel] [pve-container: Bump maximum number of container net interfaces from 10 to 32 0/1] Stephan Leemburg
@ 2020-08-23 11:38 ` Stephan Leemburg
  0 siblings, 0 replies; 4+ messages in thread
From: Stephan Leemburg @ 2020-08-23 11:38 UTC (permalink / raw)
  To: pve-devel; +Cc: Stephan Leemburg

Signed-off-by: Stephan Leemburg <stephan.leemburg@it-functions.nl>
---
 src/PVE/LXC/Config.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 5bf12d5..044e2e1 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -712,7 +712,7 @@ our $netconf_desc = {
 };
 PVE::JSONSchema::register_format('pve-lxc-network', $netconf_desc);
 
-my $MAX_LXC_NETWORKS = 10;
+my $MAX_LXC_NETWORKS = 32;
 for (my $i = 0; $i < $MAX_LXC_NETWORKS; $i++) {
     $confdesc->{"net$i"} = {
 	optional => 1,
-- 
2.25.1




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-08-27 10:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-23 11:38 [pve-devel] [pve-manager: Bump maximum number of container net interfaces from 10 to 32 0/1] Stephan Leemburg
2020-08-23 11:38 ` [pve-devel] [Bump maximum number of container net interfaces from 10 to 32 1/1] Bump maximum number of container net interfaces from 10 to 32 Stephan Leemburg
2020-08-27 10:58   ` [pve-devel] applied: " Thomas Lamprecht
  -- strict thread matches above, loose matches on Subject: below --
2020-08-23 11:38 [pve-devel] [pve-container: Bump maximum number of container net interfaces from 10 to 32 0/1] Stephan Leemburg
2020-08-23 11:38 ` [pve-devel] [Bump maximum number of container net interfaces from 10 to 32 1/1] Bump maximum number of container net interfaces from 10 to 32 Stephan Leemburg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal