public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage 1/2] prune_backups: fix message
Date: Thu, 20 Aug 2020 13:50:09 +0200	[thread overview]
Message-ID: <20200820115010.14106-1-f.ebner@proxmox.com> (raw)

For prune selections, it doesn't matter what the current time is,
only the timestamps of the backups matter.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---

Sorry for missing this when I sent the series.

 PVE/API2/Storage/PruneBackups.pm | 5 ++---
 PVE/CLI/pvesm.pm                 | 4 ++--
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/PVE/API2/Storage/PruneBackups.pm b/PVE/API2/Storage/PruneBackups.pm
index a84d1c8..2509a46 100644
--- a/PVE/API2/Storage/PruneBackups.pm
+++ b/PVE/API2/Storage/PruneBackups.pm
@@ -16,9 +16,8 @@ __PACKAGE__->register_method ({
     name => 'dryrun',
     path => '',
     method => 'GET',
-    description => "Get prune information for backups. NOTE: this is only a preview and might not be exactly " .
-		   "what a subsequent prune call does, if the hour changes or if backups are removed/added " .
-		   "in the meantime.",
+    description => "Get prune information for backups. NOTE: this is only a preview and might not be " .
+		   "what a subsequent prune call does if backups are removed/added in the meantime.",
     permissions => {
 	check => ['perm', '/storage/{storage}', ['Datastore.Audit', 'Datastore.AllocateSpace'], any => 1],
     },
diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm
index cc03e37..93ef977 100755
--- a/PVE/CLI/pvesm.pm
+++ b/PVE/CLI/pvesm.pm
@@ -932,8 +932,8 @@ our $cmddef = {
 
 	return if !$dryrun;
 
-	print "NOTE: this is only a preview and might not be exactly what a subsequent prune call does,\n" .
-	      "if the hour changes or if backups are removed/added in the meantime.\n\n";
+	print "NOTE: this is only a preview and might not be what a subsequent\n" .
+	      "prune call does if backups are removed/added in the meantime.\n\n";
 
 	my @sorted = sort {
 	    my $vmcmp = PVE::Tools::safe_compare($a->{vmid}, $b->{vmid}, sub { $_[0] <=> $_[1] });
-- 
2.20.1





             reply	other threads:[~2020-08-20 11:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20 11:50 Fabian Ebner [this message]
2020-08-20 11:50 ` [pve-devel] [PATCH storage 2/2] prune_backups CLI: print different message when there's no backups at all Fabian Ebner
2020-08-20 15:28 ` [pve-devel] applied-series: [PATCH storage 1/2] prune_backups: fix message Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200820115010.14106-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal