public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-widget-toolkit 3/5] ui: added possibility to show a small note in SafeRemove dialog
Date: Tue, 18 Aug 2020 10:40:21 +0200	[thread overview]
Message-ID: <20200818084023.54780-4-h.laimer@proxmox.com> (raw)
In-Reply-To: <20200818084023.54780-1-h.laimer@proxmox.com>

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 src/window/SafeRemove.js | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/src/window/SafeRemove.js b/src/window/SafeRemove.js
index c541272..c3fc7dd 100644
--- a/src/window/SafeRemove.js
+++ b/src/window/SafeRemove.js
@@ -21,6 +21,7 @@ Ext.define('Proxmox.window.SafeRemove', {
             type: undefined
         },
         url: undefined,
+        note: undefined,
         params: {}
     },
 
@@ -137,6 +138,22 @@ Ext.define('Proxmox.window.SafeRemove', {
                         'data-qtip': gettext('Wipe disk after the removal of mountpoint')
                     }
                 },
+                {
+                    xtype: 'container',
+                    reference: 'noteContainer',
+                    flex: 1,
+                    layout: {
+                        type: 'vbox',
+                        align: 'middle'
+                    },
+                    height: 25,
+                    items: [
+                        {
+                            xtype: 'component',
+                            reference: 'noteCmp'
+                        },
+                    ]
+                },
             ]
         }
     ],
@@ -163,8 +180,17 @@ Ext.define('Proxmox.window.SafeRemove', {
         }
 
         const messageCmp = me.lookupReference('messageCmp');
+        const noteCmp = me.lookupReference('noteCmp');
         let msg;
 
+        if (me.getNote() !== undefined) {
+            noteCmp.setHtml(`<small>${me.getNote()}</small>`);
+        } else {
+            const noteContainer = me.lookupReference('noteContainer');
+            noteContainer.setDisabled(true);
+            noteContainer.setHidden(true);
+        }
+
         if (item.type === 'VM') {
             msg = Proxmox.Utils.format_task_description('qmdestroy', item.id);
         } else if (item.type === 'CT') {
@@ -173,6 +199,8 @@ Ext.define('Proxmox.window.SafeRemove', {
             msg = Proxmox.Utils.format_task_description('cephdestroypool', item.id);
         } else if (item.type === 'Image') {
             msg = Proxmox.Utils.format_task_description('unknownimgdel', item.id);
+        } else if (item.type === 'Dir') {
+            msg = `${gettext('Directory')} ${item.id} - ${gettext('Remove')}`
         } else {
             throw "unknown item type specified";
         }
-- 
2.20.1





  parent reply	other threads:[~2020-08-18  8:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18  8:40 [pve-devel] [PATCH series 0/5] removal of directories in PBS WebUI Hannes Laimer
2020-08-18  8:40 ` [pve-devel] [PATCH proxmox-widget-toolkit 1/5] ui refactoring: refactored SafeDestroy from pve-manager into proxmox-widget-toolkit Hannes Laimer
2020-08-18 17:40   ` Thomas Lamprecht
2020-08-18  8:40 ` [pve-devel] [PATCH pve-manager 2/5] ui refactoring: SafeDestroy moved into widgettoolkit + adjusted usages Hannes Laimer
2020-08-18  8:40 ` Hannes Laimer [this message]
2020-08-18 17:59   ` [pve-devel] [PATCH proxmox-widget-toolkit 3/5] ui: added possibility to show a small note in SafeRemove dialog Thomas Lamprecht
2020-08-18  8:40 ` [pve-devel] [PATCH proxmox-backup 4/5] api2: DatastoreMountInfo now also contains the name of the mount Hannes Laimer
2020-08-18  8:40 ` [pve-devel] [PATCH proxmox-backup 5/5] ui: added possiblity to remove directories/mount-units in the WebUI Hannes Laimer
2020-08-18 17:50   ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200818084023.54780-4-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal