public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] applied: [PATCH manager] vzdump: use configured tmpdir for PBS
@ 2020-08-06 14:06 Fabian Grünbichler
  0 siblings, 0 replies; only message in thread
From: Fabian Grünbichler @ 2020-08-06 14:06 UTC (permalink / raw)
  To: pve-devel

instead of always using the default hard-coded one.

otherwise, suspend mode container backups might run out of space even
though the admin configured a big enough tmpdir.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
 PVE/VZDump.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index f80faeff..82976aa4 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -742,10 +742,10 @@ sub exec_backup_task {
 
 	$task->{vmtype} = $vmtype;
 
-	if ($self->{opts}->{pbs}) {
-	    $task->{tmpdir} = "/var/tmp/vzdumptmp$$"; #fixme
-	} elsif ($opts->{tmpdir}) {
+	if ($opts->{tmpdir}) {
 	    $task->{tmpdir} = "$opts->{tmpdir}/vzdumptmp$$";
+	} elsif ($self->{opts}->{pbs}) {
+	    $task->{tmpdir} = "/var/tmp/vzdumptmp$$"; #fixme
 	} else {
 	    # dumpdir is posix? then use it as temporary dir
 	    my $info = get_mount_info($opts->{dumpdir});
-- 
2.20.1





^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-08-06 14:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-06 14:06 [pve-devel] applied: [PATCH manager] vzdump: use configured tmpdir for PBS Fabian Grünbichler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal