From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC qemu] allow backup of read-only block drives
Date: Thu, 6 Aug 2020 13:13:49 +0200 [thread overview]
Message-ID: <20200806111349.67063-2-f.gruenbichler@proxmox.com> (raw)
In-Reply-To: <20200806111349.67063-1-f.gruenbichler@proxmox.com>
this is needed for template backups with PBS until we have the backup
equivalent of 'pbs-restore'.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
did some quick tests and didn't run into any issues - @Dietmar/@Stefan
is that check needed for some non-obvious reason?
.../0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/debian/patches/pve/0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch b/debian/patches/pve/0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch
index 56161cc..7b4834a 100644
--- a/debian/patches/pve/0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch
+++ b/debian/patches/pve/0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch
@@ -527,7 +527,7 @@ new file mode 100644
index 0000000000..9ae89fb679
--- /dev/null
+++ b/pve-backup.c
-@@ -0,0 +1,959 @@
+@@ -0,0 +1,955 @@
+#include "proxmox-backup-client.h"
+#include "vma.h"
+
@@ -1050,10 +1050,6 @@ index 0000000000..9ae89fb679
+ blk = blk_by_name(*d);
+ if (blk) {
+ bs = blk_bs(blk);
-+ if (bdrv_is_read_only(bs)) {
-+ error_setg(task->errp, "Node '%s' is read only", *d);
-+ goto err;
-+ }
+ if (!bdrv_is_inserted(bs)) {
+ error_setg(task->errp, QERR_DEVICE_HAS_NO_MEDIUM, *d);
+ goto err;
--
2.20.1
next prev parent reply other threads:[~2020-08-06 11:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 11:13 [pve-devel] [RFC qemu-server] fix #2862: properly backup (all) VM templates Fabian Grünbichler
2020-08-06 11:13 ` Fabian Grünbichler [this message]
2020-08-20 12:35 ` [pve-devel] applied: [RFC qemu] allow backup of read-only block drives Thomas Lamprecht
2020-08-21 12:13 ` [pve-devel] applied: [RFC qemu-server] fix #2862: properly backup (all) VM templates Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806111349.67063-2-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox