[pve-devel] [PATCH manager] backup: fix #2913 order jobs numerically by VMID

[pve-devel] [PATCH manager] backup: fix #2913 order jobs numerically by VMID

[Aaron Lauterer]

At this point, the VMIDs are already numerically sorted by the
PVE::VZDump::check_vmids method. Calling another sort on the array,
especially without `{$a <=> $b}`, resulted in reordering the array
alphabetically.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 PVE/VZDump.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index f80faeff..88437bd7 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -1048,7 +1048,7 @@ sub exec_backup {
     }
 
     my $vmlist = PVE::Cluster::get_vmlist();
-    foreach my $vmid (sort @{$opts->{vmids}}) {
+    foreach my $vmid (@{$opts->{vmids}}) {
 	my $guest_type = $vmlist->{ids}->{$vmid}->{type};
 	my $plugin = $vzdump_plugins->{$guest_type};
 	next if !$rpcenv->check($authuser, "/vms/$vmid", [ 'VM.Backup' ], $opts->{all});
-- 
2.20.1

[pve-devel] applied: [PATCH manager] backup: fix #2913 order jobs numerically by VMID

[Fabian Grünbichler]

On August 4, 2020 11:46 am, Aaron Lauterer wrote:
> At this point, the VMIDs are already numerically sorted by the
> PVE::VZDump::check_vmids method. Calling another sort on the array,
> especially without `{$a <=> $b}`, resulted in reordering the array
> alphabetically.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>  PVE/VZDump.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
> index f80faeff..88437bd7 100644
> --- a/PVE/VZDump.pm
> +++ b/PVE/VZDump.pm
> @@ -1048,7 +1048,7 @@ sub exec_backup {
>      }
>  
>      my $vmlist = PVE::Cluster::get_vmlist();
> -    foreach my $vmid (sort @{$opts->{vmids}}) {
> +    foreach my $vmid (@{$opts->{vmids}}) {
>  	my $guest_type = $vmlist->{ids}->{$vmid}->{type};
>  	my $plugin = $vzdump_plugins->{$guest_type};
>  	next if !$rpcenv->check($authuser, "/vms/$vmid", [ 'VM.Backup' ], $opts->{all});
> -- 
> 2.20.1
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
>