From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage 4/4] storage_migrate: log bandwidth limit
Date: Wed, 29 Jul 2020 11:44:18 +0200 [thread overview]
Message-ID: <20200729094418.20523-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20200729094418.20523-1-f.ebner@proxmox.com>
and avoid undefined post-if declaration of @cstream.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
PVE/Storage.pm | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index 6951e42..4a60615 100755
--- a/PVE/Storage.pm
+++ b/PVE/Storage.pm
@@ -637,8 +637,11 @@ sub storage_migrate {
my $ssh_base = PVE::SSHInfo::ssh_info_to_command_base($target_sshinfo);
local $ENV{RSYNC_RSH} = PVE::Tools::cmd2string($ssh_base);
- my @cstream = ([ '/usr/bin/cstream', '-t', $ratelimit_bps ])
- if defined($ratelimit_bps);
+ my @cstream;
+ if (defined($ratelimit_bps)) {
+ @cstream = ([ '/usr/bin/cstream', '-t', $ratelimit_bps ]);
+ $logfunc->("using a bandwidth limit of $ratelimit_bps bps for transferring '$volid'") if $logfunc;
+ }
my $migration_snapshot;
if (!defined($snapshot)) {
--
2.20.1
next prev parent reply other threads:[~2020-07-29 9:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 9:44 [pve-devel] [PATCH qemu-server 1/4] Use correct option for storage_migrate Fabian Ebner
2020-07-29 9:44 ` [pve-devel] [PATCH container 2/4] " Fabian Ebner
2020-07-29 9:44 ` [pve-devel] [PATCH container 3/4] Log storage_migrate output Fabian Ebner
2020-07-29 9:44 ` Fabian Ebner [this message]
2020-08-04 12:08 ` [pve-devel] applied: [PATCH qemu-server 1/4] Use correct option for storage_migrate Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729094418.20523-4-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox