[pve-devel] [PATCH docs 1/4] qdevice: Remove a wrong 's'

[pve-devel] [PATCH docs 1/4] qdevice: Remove a wrong 's'

[Dominic Jäger]

Third person plural does not require -s form.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
 pvecm.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pvecm.adoc b/pvecm.adoc
index 4bf2f59..e7b36c5 100644
--- a/pvecm.adoc
+++ b/pvecm.adoc
@@ -952,7 +952,7 @@ QDevice-Net Setup
 ~~~~~~~~~~~~~~~~~
 
 We recommend to run any daemon which provides votes to corosync-qdevice as an
-unprivileged user. {pve} and Debian provides a package which is already
+unprivileged user. {pve} and Debian provide a package which is already
 configured to do so.
 The traffic between the daemon and the cluster must be encrypted to ensure a
 safe and secure QDevice integration in {pve}.
-- 
2.20.1

[pve-devel] [PATCH docs 2/4] pvecm: Add comma after 'First'

[Dominic Jäger]

Comma after sequence words like first, next, then, or last.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
 pvecm.adoc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pvecm.adoc b/pvecm.adoc
index e7b36c5..390fb4b 100644
--- a/pvecm.adoc
+++ b/pvecm.adoc
@@ -397,7 +397,7 @@ node from the cluster.
 WARNING: Ensure all shared resources are cleanly separated! Otherwise you will
 run into conflicts and problems.
 
-First stop the corosync and the pve-cluster services on the node:
+First, stop the corosync and the pve-cluster services on the node:
 [source,bash]
 ----
 systemctl stop pve-cluster
@@ -527,7 +527,7 @@ application.
 Setting Up A New Network
 ^^^^^^^^^^^^^^^^^^^^^^^^
 
-First you have to set up a new network interface. It should be on a physically
+First, you have to set up a new network interface. It should be on a physically
 separate network. Ensure that your network fulfills the
 xref:pvecm_cluster_network_requirements[cluster network requirements].
 
@@ -957,7 +957,7 @@ configured to do so.
 The traffic between the daemon and the cluster must be encrypted to ensure a
 safe and secure QDevice integration in {pve}.
 
-First install the 'corosync-qnetd' package on your external server and
+First, install the 'corosync-qnetd' package on your external server and
 the 'corosync-qdevice' package on all cluster nodes.
 
 After that, ensure that all your nodes on the cluster are online.
-- 
2.20.1

[pve-devel] [PATCH docs 3/4] qdevice: Add note about root login requirements

[Dominic Jäger]

We mention Debian as external server before. On Debian it is easily possible
that SSH root login via password is prohibited.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
 pvecm.adoc | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/pvecm.adoc b/pvecm.adoc
index 390fb4b..47916fa 100644
--- a/pvecm.adoc
+++ b/pvecm.adoc
@@ -969,8 +969,10 @@ of the {pve} nodes:
 pve# pvecm qdevice setup <QDEVICE-IP>
 ----
 
-The SSH key from the cluster will be automatically copied to the QDevice. You
-might need to enter an SSH password during this step.
+The SSH key from the cluster will be automatically copied to the QDevice.
+
+NOTE: Make sure that the SSH configuration on your external server allows root
+login via password, if you are asked for a password during this step.
 
 After you enter the password and all the steps are successfully completed, you
 will see "Done". You can check the status now:
-- 
2.20.1

[pve-devel] [PATCH docs 4/4] qdevice: Clarify required packages

[Dominic Jäger]

I overlooked the different package names myself. Writing out the two commands
makes this more difficult to overlook.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
 pvecm.adoc | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/pvecm.adoc b/pvecm.adoc
index 47916fa..cf5f052 100644
--- a/pvecm.adoc
+++ b/pvecm.adoc
@@ -957,8 +957,17 @@ configured to do so.
 The traffic between the daemon and the cluster must be encrypted to ensure a
 safe and secure QDevice integration in {pve}.
 
-First, install the 'corosync-qnetd' package on your external server and
-the 'corosync-qdevice' package on all cluster nodes.
+First, install the 'corosync-qnetd' package on your external server
+
+----
+external# apt install corosync-qnetd
+----
+
+and the 'corosync-qdevice' package on all cluster nodes
+
+----
+pve# apt install corosync-qdevice
+----
 
 After that, ensure that all your nodes on the cluster are online.
 
-- 
2.20.1

[pve-devel] applied-series: [PATCH docs 1/4] qdevice: Remove a wrong 's'

[Fabian Grünbichler]

On July 28, 2020 11:32 am, Dominic Jäger wrote:
> Third person plural does not require -s form.
> 
> Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
> ---
>  pvecm.adoc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pvecm.adoc b/pvecm.adoc
> index 4bf2f59..e7b36c5 100644
> --- a/pvecm.adoc
> +++ b/pvecm.adoc
> @@ -952,7 +952,7 @@ QDevice-Net Setup
>  ~~~~~~~~~~~~~~~~~
>  
>  We recommend to run any daemon which provides votes to corosync-qdevice as an
> -unprivileged user. {pve} and Debian provides a package which is already
> +unprivileged user. {pve} and Debian provide a package which is already
>  configured to do so.
>  The traffic between the daemon and the cluster must be encrypted to ensure a
>  safe and secure QDevice integration in {pve}.
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>