From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [PATCH manager] fix #2890: also detect & renew DNS-only ACME certs
Date: Mon, 27 Jul 2020 10:55:35 +0200 [thread overview]
Message-ID: <20200727085535.2621695-1-f.gruenbichler@proxmox.com> (raw)
this call site was apparently missed when we refactored the node config
/ ACME interaction.
Suggested/Reported-by: Frédéric Bourqui
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
bin/pveupdate | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/bin/pveupdate b/bin/pveupdate
index 56d5d718..99b52fe9 100755
--- a/bin/pveupdate
+++ b/bin/pveupdate
@@ -60,7 +60,8 @@ if (my $err = $@) {
eval {
my $node_config = PVE::NodeConfig::load_config($nodename);
- if ($node_config && $node_config->{acme}) {
+ my $acme_node_config = PVE::NodeConfig::get_acme_conf($node_config);
+ if ($acme_node_config && $acme_node_config->{domains}) {
my $cert = PVE::CertHelpers::cert_path_prefix($nodename).".pem";
if (-e $cert) {
if (PVE::Certificate::check_expiry($cert, time() + 30*24*60*60)) {
--
2.20.1
reply other threads:[~2020-07-27 8:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727085535.2621695-1-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox