From: Alwin Antreich <a.antreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] Allow setting device class on osd create
Date: Thu, 23 Jul 2020 15:25:14 +0200 [thread overview]
Message-ID: <20200723132514.510051-1-a.antreich@proxmox.com> (raw)
In some situations Ceph's auto-detection doesn't recognize the device
class correctly. The option allows to set it directly on osd create,
instead of altering it afterwards. This way the cluster doesn't need to
shift data back and forth unnecessarily.
Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
---
PVE/API2/Ceph/OSD.pm | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm
index ceaed129..f1f39bf9 100644
--- a/PVE/API2/Ceph/OSD.pm
+++ b/PVE/API2/Ceph/OSD.pm
@@ -260,6 +260,11 @@ __PACKAGE__->register_method ({
default => 0,
description => "Enables encryption of the OSD."
},
+ 'crush-device-class' => {
+ optional => 1,
+ type => 'string',
+ description => "Set the device class of the OSD in crush."
+ },
},
},
returns => { type => 'string' },
@@ -429,7 +434,9 @@ __PACKAGE__->register_method ({
# update disklist
$disklist = PVE::Diskmanage::get_disks($devlist, 1);
+ my $dev_class = $param->{'crush-device-class'};
my $cmd = ['ceph-volume', 'lvm', 'create', '--cluster-fsid', $fsid ];
+ push @$cmd, '--crush-device-class', $dev_class if $dev_class;
my $devpath = $disklist->{$devname}->{devpath};
print "create OSD on $devpath (bluestore)\n";
--
2.26.2
next reply other threads:[~2020-07-23 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 13:25 Alwin Antreich [this message]
2020-07-24 9:34 ` [pve-devel] applied: " Thomas Lamprecht
2020-07-24 9:46 ` Alwin Antreich
2020-07-24 9:54 ` Thomas Lamprecht
2020-07-24 12:24 ` Alwin Antreich
2020-07-24 12:38 ` Thomas Lamprecht
2020-07-24 12:47 ` Alwin Antreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723132514.510051-1-a.antreich@proxmox.com \
--to=a.antreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox