* [pve-devel] [PATCH pve-docs 1/3] Fix typos and wording
@ 2020-07-15 14:26 Dylan Whyte
2020-07-15 15:16 ` Oguz Bektas
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dylan Whyte @ 2020-07-15 14:26 UTC (permalink / raw)
To: pve-devel
Update some lines to fix spelling and grammatical errors
Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
---
certificate-management.adoc | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/certificate-management.adoc b/certificate-management.adoc
index ce9081d..00633a1 100644
--- a/certificate-management.adoc
+++ b/certificate-management.adoc
@@ -104,12 +104,12 @@ the {pve} cluster under your operation, are the real owner of a domain. This is
the basis building block for automatic certificate management.
The ACME protocol specifies different types of challenges, for example the
-`http-01` where a webserver provides a file with a certain value to proof that
+`http-01` where a webserver provides a file with a certain value to prove that
it controls a domain. Sometimes this isn't possible, either because of
technical limitations or if the address a domain points to is not reachable
-from the public internet. For such cases one could use the `dns-01` challenge.
-That challenge provides also a certain value, but not over a text file, but
-through a DNS record on the authority name server of the domain.
+from the public internet. For such cases, one could use the `dns-01` challenge.
+This challenge also provides a certain value, but through a DNS record on the
+authority name server of the domain, rather than over a text file.
[thumbnail="screenshot/gui-datacenter-acme-overview.png"]
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH pve-docs 1/3] Fix typos and wording
2020-07-15 14:26 [pve-devel] [PATCH pve-docs 1/3] Fix typos and wording Dylan Whyte
@ 2020-07-15 15:16 ` Oguz Bektas
2020-07-15 16:46 ` Thomas Lamprecht
2020-07-15 16:48 ` [pve-devel] applied: " Thomas Lamprecht
2 siblings, 0 replies; 4+ messages in thread
From: Oguz Bektas @ 2020-07-15 15:16 UTC (permalink / raw)
To: Proxmox VE development discussion
lgtm
On Wed, Jul 15, 2020 at 04:26:06PM +0200, Dylan Whyte wrote:
> Update some lines to fix spelling and grammatical errors
>
> Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
> ---
> certificate-management.adoc | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/certificate-management.adoc b/certificate-management.adoc
> index ce9081d..00633a1 100644
> --- a/certificate-management.adoc
> +++ b/certificate-management.adoc
> @@ -104,12 +104,12 @@ the {pve} cluster under your operation, are the real owner of a domain. This is
> the basis building block for automatic certificate management.
>
> The ACME protocol specifies different types of challenges, for example the
> -`http-01` where a webserver provides a file with a certain value to proof that
> +`http-01` where a webserver provides a file with a certain value to prove that
> it controls a domain. Sometimes this isn't possible, either because of
> technical limitations or if the address a domain points to is not reachable
> -from the public internet. For such cases one could use the `dns-01` challenge.
> -That challenge provides also a certain value, but not over a text file, but
> -through a DNS record on the authority name server of the domain.
> +from the public internet. For such cases, one could use the `dns-01` challenge.
> +This challenge also provides a certain value, but through a DNS record on the
> +authority name server of the domain, rather than over a text file.
>
> [thumbnail="screenshot/gui-datacenter-acme-overview.png"]
>
> --
> 2.20.1
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH pve-docs 1/3] Fix typos and wording
2020-07-15 14:26 [pve-devel] [PATCH pve-docs 1/3] Fix typos and wording Dylan Whyte
2020-07-15 15:16 ` Oguz Bektas
@ 2020-07-15 16:46 ` Thomas Lamprecht
2020-07-15 16:48 ` [pve-devel] applied: " Thomas Lamprecht
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2020-07-15 16:46 UTC (permalink / raw)
To: Proxmox VE development discussion, Dylan Whyte
On 15.07.20 16:26, Dylan Whyte wrote:
> Update some lines to fix spelling and grammatical errors
>
> Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
> ---
> certificate-management.adoc | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/certificate-management.adoc b/certificate-management.adoc
> index ce9081d..00633a1 100644
> --- a/certificate-management.adoc
> +++ b/certificate-management.adoc
> @@ -104,12 +104,12 @@ the {pve} cluster under your operation, are the real owner of a domain. This is
> the basis building block for automatic certificate management.
>
> The ACME protocol specifies different types of challenges, for example the
> -`http-01` where a webserver provides a file with a certain value to proof that
> +`http-01` where a webserver provides a file with a certain value to prove that
> it controls a domain. Sometimes this isn't possible, either because of
> technical limitations or if the address a domain points to is not reachable
> -from the public internet. For such cases one could use the `dns-01` challenge.
> -That challenge provides also a certain value, but not over a text file, but
> -through a DNS record on the authority name server of the domain.
> +from the public internet. For such cases, one could use the `dns-01` challenge.
> +This challenge also provides a certain value, but through a DNS record on the
> +authority name server of the domain, rather than over a text file.
>
> [thumbnail="screenshot/gui-datacenter-acme-overview.png"]
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] applied: [PATCH pve-docs 1/3] Fix typos and wording
2020-07-15 14:26 [pve-devel] [PATCH pve-docs 1/3] Fix typos and wording Dylan Whyte
2020-07-15 15:16 ` Oguz Bektas
2020-07-15 16:46 ` Thomas Lamprecht
@ 2020-07-15 16:48 ` Thomas Lamprecht
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2020-07-15 16:48 UTC (permalink / raw)
To: Proxmox VE development discussion, Dylan Whyte
On 15.07.20 16:26, Dylan Whyte wrote:
> Update some lines to fix spelling and grammatical errors
>
> Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
> ---
> certificate-management.adoc | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-15 16:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-15 14:26 [pve-devel] [PATCH pve-docs 1/3] Fix typos and wording Dylan Whyte
2020-07-15 15:16 ` Oguz Bektas
2020-07-15 16:46 ` Thomas Lamprecht
2020-07-15 16:48 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox