From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@pve.proxmox.com
Subject: [pve-devel] [PATCH v4 manager 0/5] add backup detail and not backed up view
Date: Tue, 7 Jul 2020 11:48:57 +0200 [thread overview]
Message-ID: <20200707094902.24712-1-a.lauterer@proxmox.com> (raw)
This series add a new detail view for backup jobs to show which volumes
of a guest would be included.
Additionally it adds a notification if there are any guests not covered
by any backup job with a new window showing these guests. This is to fix
#2609.
For the latter, a new API endpoint was needed because the already
existing `cluster/backup` expects a job ID on the next level. This makes
it hard to impossible to add other endpoints there. More details are in
the actual patch.
Changes from v3 -> v4:
* switched from summary view with its own button to notification if some
guests are not backed up and changed the view to only include not
backed up guests.
* added search boxes to both the detail tree view
* removed the "not permissions for all" notification. We don't do that
anywhere else anyway and it makes the API return structure simpler and
easier to deal with
* incorporated some code style changes such as creating the object to be
pushed to the result array inline in the push operation instead of
defining it way before
Aaron Lauterer (5):
api: backup: add endpoint to list included guests and volumes
gui: dc/backup: move renderers to Utils.js
gui: dc/backup: add new backup job detail view
fix #2609 api: backupinfo: add non job specific endpoint
fix #2609 gui: backup: add window for not backed guests
PVE/API2/Backup.pm | 174 ++++++++++++
PVE/API2/BackupInfo.pm | 145 ++++++++++
PVE/API2/Cluster.pm | 6 +
PVE/API2/Makefile | 1 +
www/manager6/Utils.js | 94 +++++++
www/manager6/dc/Backup.js | 574 ++++++++++++++++++++++++++++++++++----
6 files changed, 936 insertions(+), 58 deletions(-)
create mode 100644 PVE/API2/BackupInfo.pm
--
2.20.1
next reply other threads:[~2020-07-07 9:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 9:48 Aaron Lauterer [this message]
2020-07-07 9:48 ` [pve-devel] [PATCH v4 manager 1/5] api: backup: add endpoint to list included guests and volumes Aaron Lauterer
2020-07-08 7:11 ` Thomas Lamprecht
2020-07-08 7:21 ` Aaron Lauterer
2020-07-07 9:48 ` [pve-devel] [PATCH v4 manager 2/5] gui: dc/backup: move renderers to Utils.js Aaron Lauterer
2020-07-07 9:49 ` [pve-devel] [PATCH v4 manager 3/5] gui: dc/backup: add new backup job detail view Aaron Lauterer
2020-07-07 9:49 ` [pve-devel] [PATCH v4 manager 4/5] fix #2609 api: backupinfo: add non job specific endpoint Aaron Lauterer
2020-07-07 9:49 ` [pve-devel] [PATCH v4 manager 5/5] fix #2609 gui: backup: add window for not backed guests Aaron Lauterer
2020-07-09 18:06 ` [pve-devel] applied-series: Re: [PATCH v4 manager 0/5] add backup detail and not backed up view Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707094902.24712-1-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@pve.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox