public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	"DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>,
	"aderumier@odiso.com" <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH ceph 0/2] Build rocksdb in non-debug mode
Date: Tue, 9 Jan 2024 17:12:35 +0100	[thread overview]
Message-ID: <1fc8b25b-b5fc-422e-ac76-46831dc828c7@proxmox.com> (raw)
In-Reply-To: <fcfb55d62b88fac36e51d3919dd55a35f0e50332.camel@groupe-cyllene.com>

Am 09/01/2024 um 16:46 schrieb DERUMIER, Alexandre:
> oh, I have tested with 17.2.7-pve1
> 
> 
> I'll look for 18.2

I managed to port it over, and in the second patch I squashed both
changes into one diff hunk, those two hunks touching the same file
confused me slightly initially ^^




  reply	other threads:[~2024-01-09 16:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09 14:50 Alexandre Derumier
2024-01-09 14:50 ` [pve-devel] [PATCH ceph 1/2] patch: debian/rules: fix build type Alexandre Derumier
2024-01-10  9:18   ` Fabian Grünbichler
2024-01-09 14:50 ` [pve-devel] [PATCH ceph 2/2] patch: add 0022-rocksb-inherit-parent-cmake-cxx-flags.patch Alexandre Derumier
2024-01-09 15:39 ` [pve-devel] [PATCH ceph 0/2] Build rocksdb in non-debug mode Thomas Lamprecht
2024-01-09 15:46   ` DERUMIER, Alexandre
2024-01-09 16:12     ` Thomas Lamprecht [this message]
2024-01-09 16:16       ` DERUMIER, Alexandre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fc8b25b-b5fc-422e-ac76-46831dc828c7@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=aderumier@odiso.com \
    --cc=alexandre.derumier@groupe-cyllene.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal