From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] status: influxdb: always quote tags
Date: Wed, 27 Nov 2024 20:22:00 +0100 [thread overview]
Message-ID: <1f85ec91-f957-4696-8887-21c63e59b3e0@proxmox.com> (raw)
In-Reply-To: <20241127111821.1649985-1-d.csapak@proxmox.com>
Am 27.11.24 um 12:18 schrieb Dominik Csapak:
> Since tags are mostly free-form, a single tag with a numeric value will
> get sent to influxdb as a number by default. Change that to always quote
> the tags as a string, like we do for the 'name' field. (InfluxDB can
> only have one type per field, so either a string or a number type).
>
> This won't fix influxdb databases after there are already numeric values
> in there, but I guess most tags won't be purely numeric, so this won't
> be an issue for most users, and fixes the reverse case where purely
> numeric tags won't show up in influxdb.
>
> reported in the community forum:
> https://forum.proxmox.com/threads/138004/#post-724127
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> PVE/Status/InfluxDB.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-27 19:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 11:18 [pve-devel] " Dominik Csapak
2024-11-27 19:22 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f85ec91-f957-4696-8887-21c63e59b3e0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox