[pve-devel] applied: [PATCH proxmox_dart_api_client/pve_flutter_frontend v2 0/3] fix: android: add support to honor user installed certificate

[Dominik Csapak <d.csapak@proxmox.com>]

On 9/4/25 12:09 PM, Shan Shaji wrote:
> The app was not honoring the user installed certificate and was still
> throwing `HandShakeException` when using `IOClient`. Inorder to fix the
> issue used the `cronet_http` package. This patch series only includes
> the changes specific to android.
> 
> changes since v1: https://lore.proxmox.com/pve-devel/DCJ4ONVHUS1B.2PR9TS3ZF3OE4@proxmox.com/T/#t
> - Update the commit message with more details and links
> - fixed package name not correct in the commit message.
> 
> pve_flutter_frontend:
> 
> Shan Shaji (1):
>    fix: android: add network config to support custom certificates
> 
>   android/app/src/main/AndroidManifest.xml                 | 3 ++-
>   android/app/src/main/res/xml/network_security_config.xml | 9 +++++++++
>   2 files changed, 11 insertions(+), 1 deletion(-)
>   create mode 100644 android/app/src/main/res/xml/network_security_config.xml
> 
> 
> proxmox_dart_api_client:
> 
> Shan Shaji (2):
>    fix: android: use `cronet_http` package to honor custom certificates
>    fix: add explicit throw of `HandShakeException`
> 
>   lib/src/authenticate.dart | 31 ++++++++++----
>   lib/src/utils_native.dart | 12 ++++++
>   pubspec.lock              | 89 ++++++++++++++++++++++++++++++++++++---
>   pubspec.yaml              |  1 +
>   4 files changed, 117 insertions(+), 16 deletions(-)
> 
> 
> Summary over all repositories:
>    6 files changed, 128 insertions(+), 17 deletions(-)
> 

while I'm a bit irritated how the dart/flutter devs handle this
(why not fix these issues in the dart std library instead of
publishing seperate platform specific packages... urgh)
this is a "core" package of the dart devs, so it should be
good to use here. We can always revert it if we decide to
not want to rely on an "external" library.

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel