public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Rovshan Pashayev <Rovshan.Pashayev@veeam.com>,
	"pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
	"f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com>
Cc: Pavel Tide <Pavel.TIde@veeam.com>
Subject: Re: [pve-devel]  Strange Behavior – ZFS (and other) Storage Configuration in PVE (plain text)
Date: Tue, 2 Jul 2024 13:13:58 +0200	[thread overview]
Message-ID: <1ef60445-0225-4d2d-951b-761b329fe070@proxmox.com> (raw)
In-Reply-To: <PH0PR14MB4735C14F3625AED36EA9D0589FDC2@PH0PR14MB4735.namprd14.prod.outlook.com>

Hi,

Am 02.07.24 um 12:37 schrieb Rovshan Pashayev:
> Hi Fiaona and Fabian,
> 
> I am merging your questions and answering them in this one reply (I got reply from both of you at the same time :) )
> 
>> We would like to report a strange behavior that we have encountered in Proxmox, version 8.2.2. The issue is as follows:
>> We noticed that ZFS storage configuration is missing mountpoint line randomly. And workaround is manually adding missing line.
> 
> Fabina G ====
> what exactly do you mean by this? the entry in /etc/pve/storage.cfg?
> that one should only change if you call the corresponding API endpoint
> (or CLI command). please double-check the logs that no such invocation
> is happening.
> 
> if you mean something else, please clearly describe how your system is
> configured and what the unexpected thing that is happening is.
> 
> VEEAM's REPLY ====
> We have requested info about storage using the next command: # pvesh get storage/{storageName} --output json
> As we understand, this command just parse /etc/pve/storage.cfg and return results.
> So yes, field path and mountpoint are missed in the response of mentioned command and in the file.
> But all VM’s that have disks on this storage are working normally and can be re-started.
> 

There is no 'path' property for ZFS storages in Proxmox VE. There are
'pool' and optionally 'mountpoint', see [0].

> Fiona E ====
> 
> does the option get lost for already existing storages or does it affect
> newly added ones? How do you edit/add the ZFS storages, via GUI or CLI,
> please share the exact commands in the latter case. Please also note
> that the storage configuration 'mountpoint' is optional. If it is not
> set, it will be assumed to be the default mount point, i.e. the 'pool'
> configuration option prepended by '/'.
> 
> VEEAM's REPLY =====
> Could you please confirm that if ‘mountpoint’ is missing in configuration it implicitly means that mountpoint is “/{pool_name}”?
> 

Yes, see the code below (from [1]). If the 'mountpoint' option is not
set, the pool 'option' with a prepended '/' will be used as a fallback,
as that is the default mountpoint for a ZFS dataset:

sub path {
    my ($class, $scfg, $volname, $storeid, $snapname) = @_;

    my ($vtype, $name, $vmid) = $class->parse_volname($volname);

    my $path = '';
    my $mountpoint = $scfg->{mountpoint} // "/$scfg->{pool}";


[0]:
https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage/ZFSPoolPlugin.pm;h=3669fe152b62df7ebeda572cdf56ef19be872d56;hb=13a81873ba22f37ecc0613de3f3ef994b064e3b9#l45
[1]:
https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage/ZFSPoolPlugin.pm;h=3669fe152b62df7ebeda572cdf56ef19be872d56;hb=13a81873ba22f37ecc0613de3f3ef994b064e3b9#l141

Best Regards,
Fiona


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

       reply	other threads:[~2024-07-02 11:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <PH0PR14MB4735C14F3625AED36EA9D0589FDC2@PH0PR14MB4735.namprd14.prod.outlook.com>
2024-07-02 11:13 ` Fiona Ebner [this message]
2024-07-02 11:55   ` Rovshan Pashayev via pve-devel
2024-07-02 10:37 Rovshan Pashayev via pve-devel
     [not found] <PH0PR14MB473575CF68BA7648A63F70BC9FDC2@PH0PR14MB4735.namprd14.prod.outlook.com>
2024-07-02  9:00 ` Fiona Ebner
  -- strict thread matches above, loose matches on Subject: below --
2024-07-02  8:48 Rovshan Pashayev via pve-devel
2024-07-02  9:00 ` Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ef60445-0225-4d2d-951b-761b329fe070@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=Pavel.TIde@veeam.com \
    --cc=Rovshan.Pashayev@veeam.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal