* Re: [pve-devel] [PATCH v2 container 1/1] pct gentoo plugin fix for systemd
[not found] <010f0187fba01af0-e214c42c-b27c-4b5c-9275-c171cf34da10-000000@us-east-2.amazonses.com>
@ 2023-06-16 14:04 ` Thomas Lamprecht
0 siblings, 0 replies; only message in thread
From: Thomas Lamprecht @ 2023-06-16 14:04 UTC (permalink / raw)
To: Jorge Ventura, pve-devel
Am 08/05/2023 um 15:49 schrieb Jorge Ventura:
> ---
> Create variable 'inittype' in the class Gentoo to establish 'openrc' or 'systemd' procedure and implement in self_init the logic for 'inittype' based on 'systemd' in the '/sbin/init' symlink.
> For self->{inittype} = 'openrc', the previous logic is preserved; but for self->{inittype} = 'systemd', the following was implemented:
> 1. In set_hostname function, the content removed the key 'hostname='.
> 2. In setup_network function, the logic configure '/etc/systemd/network/<eth>.network' file as defined for systemd standard.
> The v2 just fix the 'open' parameter to FH to remove warning.
>
looks OK, I'd apply this with a few small stylistic fixes as followup, but I'd
require your S-o-b here, it would be enough if you reply to this mail with (an
adapted) line like:
Signed-off-by: Full Name <email@address.example.com>
thanks!
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-16 14:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <010f0187fba01af0-e214c42c-b27c-4b5c-9275-c171cf34da10-000000@us-east-2.amazonses.com>
2023-06-16 14:04 ` [pve-devel] [PATCH v2 container 1/1] pct gentoo plugin fix for systemd Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox