From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Jorge Ventura <jorge.araujo.ventura@gmail.com>,
pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v2 container 1/1] pct gentoo plugin fix for systemd
Date: Fri, 16 Jun 2023 16:04:57 +0200 [thread overview]
Message-ID: <1ec14ceb-5f4b-5cf1-91e5-2799861a510a@proxmox.com> (raw)
In-Reply-To: <010f0187fba01af0-e214c42c-b27c-4b5c-9275-c171cf34da10-000000@us-east-2.amazonses.com>
Am 08/05/2023 um 15:49 schrieb Jorge Ventura:
> ---
> Create variable 'inittype' in the class Gentoo to establish 'openrc' or 'systemd' procedure and implement in self_init the logic for 'inittype' based on 'systemd' in the '/sbin/init' symlink.
> For self->{inittype} = 'openrc', the previous logic is preserved; but for self->{inittype} = 'systemd', the following was implemented:
> 1. In set_hostname function, the content removed the key 'hostname='.
> 2. In setup_network function, the logic configure '/etc/systemd/network/<eth>.network' file as defined for systemd standard.
> The v2 just fix the 'open' parameter to FH to remove warning.
>
looks OK, I'd apply this with a few small stylistic fixes as followup, but I'd
require your S-o-b here, it would be enough if you reply to this mail with (an
adapted) line like:
Signed-off-by: Full Name <email@address.example.com>
thanks!
parent reply other threads:[~2023-06-16 14:04 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <010f0187fba01af0-e214c42c-b27c-4b5c-9275-c171cf34da10-000000@us-east-2.amazonses.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ec14ceb-5f4b-5cf1-91e5-2799861a510a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=jorge.araujo.ventura@gmail.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox