public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Markus Frank <m.frank@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server v1 1/3] vga: allow live-migration with clipboard
Date: Mon, 17 Nov 2025 17:42:12 +0100	[thread overview]
Message-ID: <1e5dc1f7-539f-46c3-b79b-de186a3ea89d@proxmox.com> (raw)
In-Reply-To: <20251117162819.465530-2-m.frank@proxmox.com>

Am 17.11.25 um 5:28 PM schrieb Markus Frank:
> The live-migration feature now works with qemu's upstream commit:
> 5d56bff11e ("ui/vdagent: add migration support")
> 
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
>  src/PVE/API2/Qemu.pm   | 5 -----
>  src/PVE/QemuMigrate.pm | 5 -----
>  src/PVE/QemuServer.pm  | 2 +-
>  3 files changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
> index 02f5caec..314b6a48 100644
> --- a/src/PVE/API2/Qemu.pm
> +++ b/src/PVE/API2/Qemu.pm
> @@ -5267,11 +5267,6 @@ __PACKAGE__->register_method({
>          my ($local_resources, $mapped_resources, $missing_mappings_by_node) =
>              PVE::QemuMigrate::Helpers::check_local_resources($vmconf, $res->{running}, 1);
>  
> -        my $vga = PVE::QemuServer::parse_vga($vmconf->{vga});
> -        if ($res->{running} && $vga->{'clipboard'} && $vga->{'clipboard'} eq 'vnc') {
> -            push $local_resources->@*, "clipboard=vnc";
> -        }

I suppose this depends on having machine version >= 10.1, or? (In any
case QEMU binary version >= 10.1 but that is implied by machine version
>= 10.1)

> -
>          $res->{allowed_nodes} = [];
>          $res->{not_allowed_nodes} = {};
> 


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-11-17 16:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17 16:26 [pve-devel] [PATCH qemu-server/manager/docs v1 0/3] Live-Migration with VNC clipboard Markus Frank
2025-11-17 16:26 ` [pve-devel] [PATCH qemu-server v1 1/3] vga: allow live-migration with clipboard Markus Frank
2025-11-17 16:42   ` Fiona Ebner [this message]
2025-11-17 16:43     ` Fiona Ebner
2025-11-19 14:18       ` Markus Frank
2025-11-19 14:46         ` Fiona Ebner
2025-11-17 16:26 ` [pve-devel] [PATCH manager v1 2/3] ui: display: remove 'vncMigration' hint Markus Frank
2025-11-17 16:26 ` [pve-devel] [PATCH docs v1 3/3] clipboard: remove 'live-migration not possible' note Markus Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e5dc1f7-539f-46c3-b79b-de186a3ea89d@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=m.frank@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal