Re: [pve-devel] [RFC storage 1/7] storage: expose find_free_diskname

[Fabian Ebner <f.ebner@proxmox.com>]

Am 01.06.21 um 18:10 schrieb Aaron Lauterer:
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>   PVE/Storage.pm | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/PVE/Storage.pm b/PVE/Storage.pm
> index aa36bad..93d09ce 100755
> --- a/PVE/Storage.pm
> +++ b/PVE/Storage.pm
> @@ -201,6 +201,14 @@ sub storage_can_replicate {
>       return $plugin->storage_can_replicate($scfg, $storeid, $format);
>   }
>   
> +sub find_free_diskname {
> +    my ($cfg, $storeid, $vmid, $fmt, $add_fmt_suffix) = @_;

Nit: Ideally, the $add_fmt_suffix should be decided by the plugin, as an 
outside caller cannot know what a plugin wants/expects. Don't know if 
that's easy to do the way things are though.

> +
> +    my $scfg = storage_config($cfg, $storeid);
> +    my $plugin = PVE::Storage::Plugin->lookup($scfg->{type});
> +    return $plugin->find_free_diskname($storeid, $scfg, $vmid, $fmt, $add_fmt_suffix);
> +}
> +
>   sub storage_ids {
>       my ($cfg) = @_;
>   
>