From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH manager 1/2] vzdump: warn when both storage and dumpdir are defined in vzdump.conf
Date: Mon, 7 Dec 2020 10:55:12 +0100 [thread overview]
Message-ID: <1e3ffcfc-06e6-34a4-ee2f-99a0e0089be6@proxmox.com> (raw)
In-Reply-To: <20201204091518.15237-1-f.ebner@proxmox.com>
On 04.12.20 10:15, Fabian Ebner wrote:
> and prefer storage, because the storage configuration might contain more
> settings. Warning is preferable over dying, because all backups would be
> affected (even if they don't use the vzdump.conf parameters) and the settings
> could've been compatible (i.e. dumpdir being the storage's dump dir). Previously
> one of the two options would randomly be chosen in the loop in new(), because of
> perl hash iteration.
>
> Reported here: https://forum.proxmox.com/threads/vzdump-times-out-very-often-on-zfs-storage-pool.80035/post-354277
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/VZDump.pm | 5 +++++
> 1 file changed, 5 insertions(+)
>
>
applied both patches, thanks!
prev parent reply other threads:[~2020-12-07 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 9:15 [pve-devel] " Fabian Ebner
2020-12-04 9:15 ` [pve-devel] [PATCH manager 2/2] vzdump: use debugmsg instead of warn Fabian Ebner
2020-12-07 9:55 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e3ffcfc-06e6-34a4-ee2f-99a0e0089be6@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox