From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer v2] low level: testmode: take path to disk image instead of using /dev/null
Date: Thu, 9 Nov 2023 14:46:06 +0100 [thread overview]
Message-ID: <1e3f1880-f912-48e6-aacd-984d14f9a667@proxmox.com> (raw)
In-Reply-To: <20231109094758.335216-1-c.heiss@proxmox.com>
Am 09/11/2023 um 10:47 schrieb Christoph Heiss:
> .. in exactly the same way GUI and TUI installer do, streamlining them.
>
> Up until now, testing the TUI installer often involved hand-editing the
> `run-env-info.json` to put some proper disk sizes > 0 in place. This
> makes this process a lot easier.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> v1: https://lists.proxmox.com/pipermail/pve-devel/2023-October/059311.html
>
> Changes v1 -> v2:
> * rebased on latest master
>
> Makefile | 15 ++++++++++-----
> proxmox-low-level-installer | 8 ++++----
> 2 files changed, 14 insertions(+), 9 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-11-09 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 9:47 [pve-devel] " Christoph Heiss
2023-11-09 13:46 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e3f1880-f912-48e6-aacd-984d14f9a667@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal