From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH manager] fix #4808: ceph: use setting names with underscores
Date: Thu, 7 Sep 2023 11:07:18 +0200 [thread overview]
Message-ID: <1e15b427-485d-4530-ae38-76cdbf757742@proxmox.com> (raw)
In-Reply-To: <75631e85-0440-46c7-a359-ab0d9a80209a@proxmox.com>
> Also, did you checked for other such occurrences in our API?
I found another place where they are used in pve-manager's PVE/API2/Ceph module.
I will send a patch, but most interesting is that we set
$cfg->{global}->{'osd pg bits'} = $param->{pg_bits};
$cfg->{global}->{'osd pgp bits'} = $param->{pg_bits};
and expose them in the API. This setting is documented in the Pacific docs [1],
but not in the Quincy docs [2]. I could not find much info about this. It is not
mentioned on the Quincy release notes [3] as far as I can tell.
[1] https://docs.ceph.com/en/pacific/rados/configuration/pool-pg-config-ref/
[2] https://docs.ceph.com/en/quincy/rados/configuration/pool-pg-config-ref/
[3] https://docs.ceph.com/en/latest/releases/quincy/#v17-2-0-quincy
next prev parent reply other threads:[~2023-09-07 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 8:53 [pve-devel] " Maximiliano Sandoval
2023-09-06 14:57 ` [pve-devel] applied: " Thomas Lamprecht
2023-09-07 9:07 ` Maximiliano Sandoval [this message]
2023-09-07 9:30 ` Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e15b427-485d-4530-ae38-76cdbf757742@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox