public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Markus Frank <m.frank@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server v2 1/5] enable clipboard parameter in vga_fmt
Date: Fri, 21 Oct 2022 14:45:08 +0200	[thread overview]
Message-ID: <1dc02892-cecc-7758-d0dc-3836bc6f55ee@proxmox.com> (raw)
In-Reply-To: <20221020111443.158234-1-m.frank@proxmox.com>

High level comments after playing around with it:

is it really not possible to have c&p working for both novnc and spice?

AFAICS the qemu-vdagent chardev replaces spicevmc, but that means one
can either have c&p in spice OR vnc, but never both at the same time
(shame really, since i don't think it would be much work.. but of course
i'm not very familiar with the qemu code for this)

in that case, i would either:

* not allow to enable this when SPICE is selected as a gpu
or
* make it *very* clear in the ui and documentation that both
   simultaneously don't work (e.g. put a yellow warning under the checkbox)

also, it should be much clearer in the GUI  (and option documentation) that
it's necessary to install the spice client in the guest for this to work.
As it is, we'd get many confused users asking 'why doesn't it work' just
because they don't know it only works with the spice guest tools + a
graphical ui in the vm

A smaller (but important) thing is that i'd like to see a new cfg2cmd test
for new options. it should be enough to enable that option for an existing
test and adapt the output (or make a new test case).




      parent reply	other threads:[~2022-10-21 12:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20 11:14 Markus Frank
2022-10-20 11:14 ` [pve-devel] [PATCH qemu-server 2/5] added clipboard variable to return at status/current Markus Frank
2022-10-20 11:14 ` [pve-devel] [PATCH novnc 3/5] added show clipboard button patch to series Markus Frank
2022-10-20 11:14 ` [pve-devel] [PATCH manager 4/5] added clipboard checkbox to DisplayEdit Markus Frank
2022-10-20 11:14 ` [pve-devel] [PATCH docs 5/5] added noVNC clipboard documentation Markus Frank
2022-10-21 12:47   ` Dominik Csapak
2022-10-21 12:45 ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1dc02892-cecc-7758-d0dc-3836bc6f55ee@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=m.frank@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal