From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Oguz Bektas <o.bektas@proxmox.com>
Subject: [pve-devel] applied: [PATCH v5 container 0/4] post_clone_hook for containers
Date: Fri, 18 Jun 2021 18:18:26 +0200 [thread overview]
Message-ID: <1cf7d618-6cbe-0d25-49e9-fd3cfb1b0362@proxmox.com> (raw)
In-Reply-To: <20210617105201.804786-1-o.bektas@proxmox.com>
On 17.06.21 12:51, Oguz Bektas wrote:
> add post clone hook, and fix #3443 to clear machine-id for cloned
> containers
>
>
> v4->v5:
> * split patches for easy review/backport
> * also lock when moving config to target node
> * move create_and_lock_config outside the eval, this should be checked
> before the other ones
>
>
> Oguz Bektas (4):
> setup: add post_clone_hook for containers
> clone_vm: improve config locking
> run post_clone_hook in clone_vm API
> clone_vm: fix minor typo in error message
>
> src/PVE/API2/LXC.pm | 55 +++++++++++++++++++++++++++------------
> src/PVE/LXC/Setup.pm | 12 +++++++++
> src/PVE/LXC/Setup/Base.pm | 31 ++++++++++++++++++++++
> 3 files changed, 81 insertions(+), 17 deletions(-)
>
applied with Fabians followups (thanks for those!), but it is still buggy then, i.e.,
- LXC::Setup post_clone_hook was just completely off
- if a (non-systemd) CT without any /etc/machine-id present gets cloned it suddenly
gets an empty one?
so pushed out two followups to fix that mess...
prev parent reply other threads:[~2021-06-18 16:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 10:51 [pve-devel] " Oguz Bektas
2021-06-17 10:51 ` [pve-devel] [PATCH v5 container 1/4] setup: add " Oguz Bektas
2021-06-18 15:59 ` Thomas Lamprecht
2021-06-17 10:51 ` [pve-devel] [PATCH v5 container 2/4] clone_vm: improve config locking Oguz Bektas
2021-06-17 10:52 ` [pve-devel] [PATCH v5 container 3/4] run post_clone_hook in clone_vm API Oguz Bektas
2021-06-17 10:52 ` [pve-devel] [PATCH v5 container 4/4] clone_vm: fix minor typo in error message Oguz Bektas
2021-06-18 12:51 ` [pve-devel] [PATCH container 0/6] clone_vm follow-ups Fabian Grünbichler
2021-06-18 12:51 ` [pve-devel] [PATCH container 1/6] clone_vm: use move_config_to_node Fabian Grünbichler
2021-06-18 12:51 ` [pve-devel] [PATCH container 2/6] clone_vm: use destroy_config instead of manual unlink Fabian Grünbichler
2021-06-18 12:51 ` [pve-devel] [PATCH container 3/6] clone_vm: reduce source flock scope Fabian Grünbichler
2021-06-18 12:51 ` [pve-devel] [PATCH container 4/6] clone_vm: move linked clone check in eval Fabian Grünbichler
2021-06-18 12:51 ` [pve-devel] [PATCH container 5/6] clone_vm: refactor locking further Fabian Grünbichler
2021-06-18 12:51 ` [pve-devel] [PATCH container 6/6] clone_vm: rework firewall config cloning Fabian Grünbichler
2021-06-18 16:18 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cf7d618-6cbe-0d25-49e9-fd3cfb1b0362@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox