Re: [pve-devel] [PATCH storage/qemu-server/manager v6] implement ova/ovf import for file based storages

From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Lukas Wagner <l.wagner@proxmox.com>,
	d.csapak@proxmox.com
Subject: Re: [pve-devel] [PATCH storage/qemu-server/manager v6] implement ova/ovf import for file based storages
Date: Tue, 19 Nov 2024 09:48:36 +0100	[thread overview]
Message-ID: <1c8f245c-ac98-4633-9c10-69e6a7dd7b2a@proxmox.com> (raw)
In-Reply-To: <D5Q07WV14ROB.3BIJYETI77TBU@proxmox.com>

Am 19.11.24 um 09:15 schrieb Lukas Wagner:
> On Mon Nov 18, 2024 at 2:53 PM CET, Dominik Csapak wrote:
>>>> nothing special, I tested the feature using the Home Assistant .ova from
>>>> [1]. Downloaded the OVA to my local storage, pressed "import", did not
>>>> change *any* settings apart from ticking "live import".
>>>> The import works, but the VM is not started. Starting the VM manually
>>>> works fine, also the tasks log does not show anything of concern.
>>>> In the browser network requests I saw that 'live-restore' is set to '1'
>>>> in the import POST request.
>>>>
>>>> [1] https://www.home-assistant.io/installation/alternative/
>>>
>>>
>>> mhmm can reproduce with that ova image, maybe it has something to do with our
>>> ovf import not detecting the main disk?
>>> (at least here it does not detect any disk)
>>>
>>>
>>
>> ok two things here:
>>
>> * this ova is malformed it seems, it has a HostResource of '/disk/vmidsk1' when
>> the spec says it should be of the form 'ovf:/disk/vmdisk1' which is what we look for
>> (we could make that optional though?)
>>
>> * seemingly live-import does not start the vm if there was no disk, but AFAICS
>> this was pre-existing and not something my series introduced (but not sure either)
>>
> 
> Ah, thanks for the investigation. Maybe it'd be worth to check whether
> other hypervisors accept the malformed resource definition and then add
> support to PVE as well if this is the case.

Btw. it should work now already, the GNS3 image that Filip linked to in his reply
used the same format, so this seems to be relatively common.

I used the GNS3 one yesterday as test case to integrate some detection quirks, I
also had to accept whitespace in the OVA disk names (we normalize those as standard
PVE volume name through import anyway).

I then also imported A HAOS OVA image, that works in general, but the disk was not
added as boot device, and the disk bus was LSI, I needed to change both to make the
disk available for OVMF. IIRC the OS type was detected "Others" on import, I changed
that, but seems not all defaults changed with it – maybe one could look into that?
HAOS is a common usecase, I alone installed it twice this year, back then I had to
use the qcow2 image and manually import that like a cave man though hehe

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel