public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stefan Reiter <s.reiter@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] bootorder: don't print empty 'order=' property
Date: Thu, 22 Oct 2020 08:47:59 +0200	[thread overview]
Message-ID: <1c7ca566-adbf-b706-a439-84adba049b32@proxmox.com> (raw)
In-Reply-To: <20201021090025.13321-1-s.reiter@proxmox.com>

On 21.10.20 11:00, Stefan Reiter wrote:
> Specifying 'boot: order=' was intended to be used for an empty bootorder
> (i.e. no boot devices), but as it turns out our format parser doesn't
> like empty '-list' properties if they are nested in a subformat.
> 
> Fixing this in JSONSchema sounds like a risky move, so instead just
> write 'boot: ' (without 'order=') to indicate an empty bootorder. The
> rest of the code handles it just fine, as this was valid before too.
> 
> Incidentally also fixes a bug where you couldn't create a new VM without
> any disks if no explicit 'boot' property was specified (i.e. a simple
> 'qm create 100' without any parameters would fail).
> 
> Reported-by: Dominic Jäger <d.jaeger@proxmox.com>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>  PVE/QemuServer.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!





      reply	other threads:[~2020-10-22  6:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-21  9:00 [pve-devel] " Stefan Reiter
2020-10-22  6:47 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c7ca566-adbf-b706-a439-84adba049b32@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.reiter@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal