From: Lukas Wagner <l.wagner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 manager] ui: backup: replication: replace non-clickable checkbox with icons
Date: Tue, 24 Jan 2023 16:37:23 +0100 [thread overview]
Message-ID: <1c15fff5-dfa8-c505-8754-1d5996f15a46@proxmox.com> (raw)
In-Reply-To: <b00f4b14-47cb-5c2b-c811-256be1216bd0@proxmox.com>
On 1/24/23 16:28, Thomas Lamprecht wrote:
>
> you break setting dataIndex by writing it all lowercase ?!
>
>> + align: 'center',
>> + renderer: function(enabled, cell, record) {
>> + return Proxmox.Utils.render_enabled_icon(record.data.enabled);
>> + },
>
>
> with data index fixed, this could be:
>
>
> renderer: Proxmox.Utils.renderEnabledIcon,
>
> Or if you really want to avoid passing the remaining params to the renderer:
>
> renderer: enabled => Proxmox.Utils.renderEnabledIcon(enabled),
>
> but normally that's really not a problem for renders.
>
Ooooh, and I kept wondering why `renderer` did not behave as in other places.
Missspelled `dataIndex` must have snuck in as a copy-paste error, thanks for pointing this out.
--
- Lukas
prev parent reply other threads:[~2023-01-24 15:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 13:17 [pve-devel] [PATCH v2 manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes " Lukas Wagner
2023-01-23 13:17 ` [pve-devel] [PATCH v2 widget-toolkit 1/1] repo view: replace non-clickable checkbox " Lukas Wagner
2023-01-24 15:24 ` Thomas Lamprecht
2023-01-24 15:30 ` Thomas Lamprecht
2023-01-23 13:17 ` [pve-devel] [PATCH v2 manager] ui: backup: replication: " Lukas Wagner
2023-01-24 15:28 ` Thomas Lamprecht
2023-01-24 15:37 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c15fff5-dfa8-c505-8754-1d5996f15a46@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox