[pve-devel] [PATCH pve-manager] NetworkEdit: allow setting 'mtu' option for guest network devices

[pve-devel] [PATCH pve-manager] NetworkEdit: allow setting 'mtu' option for guest network devices

[Oguz Bektas]

we already have the 'mtu' option inside the API, so we can just expose
that option inside the 'Advanced' menu for guest network interfaces.

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 www/manager6/qemu/NetworkEdit.js | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
index b39cffdc..4ce7e7a2 100644
--- a/www/manager6/qemu/NetworkEdit.js
+++ b/www/manager6/qemu/NetworkEdit.js
@@ -19,6 +19,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
 	me.network.macaddr = values.macaddr;
 	me.network.disconnect = values.disconnect;
 	me.network.queues = values.queues;
+	me.network.mtu = values.mtu;
 
 	if (values.rate) {
 	    me.network.rate = values.rate;
@@ -112,6 +113,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
 			    'macaddr',
 			    'rate',
 			    'queues',
+			    'mtu',
 			];
 			fields.forEach(function(fieldname) {
 			    me.down('field[name='+fieldname+']').setDisabled(value);
@@ -161,6 +163,13 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
 		value: '',
 		allowBlank: true,
 	    },
+	    {
+		xtype: 'proxmoxintegerfield',
+		name: 'mtu',
+		fieldLabel: 'MTU',
+		value: '',
+		allowBlank: true,
+	    },
 	];
 
 	me.callParent();
-- 
2.30.2

Re: [pve-devel] [PATCH pve-manager] NetworkEdit: allow setting 'mtu' option for guest network devices

[Dylan Whyte]

Hi,

Tested on Linux (Fedora 32 & Debian 11) and Windows 2019 server, and all 
seems to work.

Best regards,

Dylan


On 2/7/22 13:18, Oguz Bektas wrote:
> we already have the 'mtu' option inside the API, so we can just expose
> that option inside the 'Advanced' menu for guest network interfaces.
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>   www/manager6/qemu/NetworkEdit.js | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
> index b39cffdc..4ce7e7a2 100644
> --- a/www/manager6/qemu/NetworkEdit.js
> +++ b/www/manager6/qemu/NetworkEdit.js
> @@ -19,6 +19,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
>   	me.network.macaddr = values.macaddr;
>   	me.network.disconnect = values.disconnect;
>   	me.network.queues = values.queues;
> +	me.network.mtu = values.mtu;
>   
>   	if (values.rate) {
>   	    me.network.rate = values.rate;
> @@ -112,6 +113,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
>   			    'macaddr',
>   			    'rate',
>   			    'queues',
> +			    'mtu',
>   			];
>   			fields.forEach(function(fieldname) {
>   			    me.down('field[name='+fieldname+']').setDisabled(value);
> @@ -161,6 +163,13 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
>   		value: '',
>   		allowBlank: true,
>   	    },
> +	    {
> +		xtype: 'proxmoxintegerfield',
> +		name: 'mtu',
> +		fieldLabel: 'MTU',
> +		value: '',
> +		allowBlank: true,
> +	    },
>   	];
>   
>   	me.callParent();


Tested-by: Dylan Whyte <d.whyte@proxmox.com>

Re: [pve-devel] [PATCH pve-manager] NetworkEdit: allow setting 'mtu' option for guest network devices

[Thomas Lamprecht]

commit subject should rather be

"ui: vm network: allow to override mtu for virtio devices"

On 07.02.22 13:18, Oguz Bektas wrote:
> we already have the 'mtu' option inside the API, so we can just expose
> that option inside the 'Advanced' menu for guest network interfaces.

We have that property since commit 61a14cde8d568e552d3deaab2da76b479b8aca7b but
it's only effective for when the VirtIO driver is used. The ui should reflect
that as it may get really confusing for users with e1000(e) or other non-virtio
models. MTU changes are notoriously tricky as it needs to be right in the whole
network path, so the UX is IMO important for this

Re: [pve-devel] [PATCH pve-manager] NetworkEdit: allow setting 'mtu' option for guest network devices

[Oguz Bektas]

hi,

thx for the review :)

On Wed, Feb 09, 2022 at 07:03:34PM +0100, Thomas Lamprecht wrote:
> commit subject should rather be
> 
> "ui: vm network: allow to override mtu for virtio devices"

okay

> 
> On 07.02.22 13:18, Oguz Bektas wrote:
> > we already have the 'mtu' option inside the API, so we can just expose
> > that option inside the 'Advanced' menu for guest network interfaces.
> 
> We have that property since commit 61a14cde8d568e552d3deaab2da76b479b8aca7b but
> it's only effective for when the VirtIO driver is used. The ui should reflect
> that as it may get really confusing for users with e1000(e) or other non-virtio
> models. MTU changes are notoriously tricky as it needs to be right in the whole
> network path, so the UX is IMO important for this

ah that's true! i'll send in a v2 :)