Re: [pve-devel] [PATCH ha-manager 2/2] fix #6801: only consider target node during positive resource affinity migration

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 03.11.25 um 16:18 schrieb Daniel Kral:
> When a HA resource with positive affinity to other HA resources is moved
> to another node, the other HA resources in positive affinity are
> automatically moved to the same target node as well.
> 
> If the HA resources have significant differences in migration time
> (more than the average HA Manager round of ~10 seconds) the already
> migrated HA resources in 'started' state will check for better node
> placements while the other(s) are still migrating.

 
> This search includes whether the positive resource affinity rules are
> held and will query where the other HA resources are. When HA resources
> are still migrating this will report that these are both on the source
> and target node, which is correct from a accounting standpoint, but will
> add equal weights on both nodes and might result in the already started
> HA resource to be migrated to the source node.

So, just to confirm, this does not change the accounting part at all, or?

Patch looks OK to me in general though, but would like to recheck with
a slightly fresher mind tomorrow, maybe we could have a quick chat too
for clearing this up.

> 
> Therefore, only consider the target node for positive affinity during
> migration or relocation to prevent this from happening.
> 
> As a side-effect, two test cases for positive resource affinity rules
> will result in a slightly quicker convergence to a steady state as these
> now will get the information about the common target node sooner.
> 
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
>  src/PVE/HA/Rules/ResourceAffinity.pm          |  6 ++--
>  .../log.expect                                | 25 +++--------------
>  .../log.expect                                | 28 +++++++++----------
>  .../README                                    |  3 --
>  .../log.expect                                | 28 +++----------------
>  5 files changed, 26 insertions(+), 64 deletions(-)
> 
> diff --git a/src/PVE/HA/Rules/ResourceAffinity.pm b/src/PVE/HA/Rules/ResourceAffinity.pm
> index 4f5ffca5..9303bafd 100644
> --- a/src/PVE/HA/Rules/ResourceAffinity.pm
> +++ b/src/PVE/HA/Rules/ResourceAffinity.pm
> @@ -517,8 +517,10 @@ sub get_resource_affinity {
>      for my $csid (keys $positive->%*) {
>          my ($current_node, $target_node) = $get_used_service_nodes->($csid);
>  
> -        $together->{$current_node}++ if defined($current_node);
> -        $together->{$target_node}++ if defined($target_node);
> +        # consider only the target node for positive affinity to prevent already
> +        # moved HA resources to move back to the source node (see #6801)
> +        my $node = $target_node // $current_node;
> +        $together->{$node}++ if defined($node);
>      }
>  
>      for my $csid (keys $negative->%*) {



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel