From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server v2 4/6] tests: add migration alias check
Date: Wed, 24 May 2023 16:41:04 +0200 [thread overview]
Message-ID: <1bdf402d-0b40-ce6e-265d-2db704352954@proxmox.com> (raw)
In-Reply-To: <5124c3a2-5295-7a97-c9b8-60205682737c@proxmox.com>
On 5/22/23 16:25, Fiona Ebner wrote:
> Am 12.05.23 um 14:40 schrieb Aaron Lauterer:
>> @@ -355,6 +382,13 @@ my $source_vdisks = {
>> 'vmid' => '111',
>> 'volid' => 'local-zfs:vm-111-disk-0',
>> },
>> + {
>> + 'ctime' => '1589277334',
>> + 'format' => 'raw',
>> + 'size' => 4294967296,
>> + 'vmid' => '123',
>> + 'volid' => 'local-zfs:vm-123-disk-0',
>> + },
>
> A disk should also be added to alias-zfs. And actually, let's not make
> alias-zfs reference "rpool/data", but add a second alias-zfs-2 or
> something. Otherwise, we would need to add all disks currently in
> local-zfs to alias-zfs too, to stay consistent with what we model.
>
good point. will do :)
>> {
>> 'format' => 'raw',
>> 'name' => 'vm-4567-disk-0',
>
next prev parent reply other threads:[~2023-05-24 14:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 12:40 [pve-devel] [PATCH qemu-server, container v2 0/6] migration: don't scan all storages, fail on aliases Aaron Lauterer
2023-05-12 12:40 ` [pve-devel] [PATCH qemu-server v2 1/6] migration: only migrate disks used by the guest Aaron Lauterer
2023-05-22 11:59 ` Fiona Ebner
2023-05-24 15:00 ` Aaron Lauterer
2023-05-12 12:40 ` [pve-devel] [PATCH qemu-server v2 2/6] tests: add migration test for pending disk Aaron Lauterer
2023-05-22 14:02 ` Fiona Ebner
2023-05-12 12:40 ` [pve-devel] [PATCH qemu-server v2 3/6] migration: fail when aliased volume is detected Aaron Lauterer
2023-05-22 14:17 ` Fiona Ebner
2023-05-24 14:40 ` Aaron Lauterer
2023-05-25 8:14 ` Fiona Ebner
2023-05-25 8:15 ` Fiona Ebner
2023-05-12 12:40 ` [pve-devel] [PATCH qemu-server v2 4/6] tests: add migration alias check Aaron Lauterer
2023-05-22 14:25 ` Fiona Ebner
2023-05-24 14:41 ` Aaron Lauterer [this message]
2023-05-12 12:40 ` [pve-devel] [PATCH container v2 5/6] migration: only migrate volumes used by the guest Aaron Lauterer
2023-05-22 15:00 ` Fiona Ebner
2023-05-12 12:40 ` [pve-devel] [PATCH container v2 6/6] migration: fail when aliased volume is detected Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bdf402d-0b40-ce6e-265d-2db704352954@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox