From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH manager] api/ui: include the node ha status in resources call and show as icon
Date: Wed, 13 Nov 2024 10:16:03 +0100 [thread overview]
Message-ID: <1bac79ec-7598-4c8d-952f-a394044a08cb@proxmox.com> (raw)
In-Reply-To: <3725cde0-842b-4fd7-b352-e3336e1b6d20@proxmox.com>
On 2024-11-12 20:49, Thomas Lamprecht wrote:
> Am 31.05.24 um 10:07 schrieb Dominik Csapak:
>> we already have the information parsed, so it's cheap, and we already
>> have a mechanism in place that adds 'ha-<hastate>' as a css class, so
>> let's reuse that.
>>
>> I chose a yellow wrench, as wrenches are associated with 'maintenance',
>> and because the state warrants more notice than 'online' but less than
>> 'offline'.
>>
>> Users mentioned in the forum that this would be nice:
>> https://forum.proxmox.com/threads/125768/
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> not sure about the color, since the yellow has relatively low contrast
>> in the light mode (in dark mode it's fine). It's the same yellow as for
>> 'io-errors' though.
>
> maybe blue as more of a "notice" color, this state is not problematic per
> se after all.
Some thoughts from my side:
We use #3892d4 for the Ceph PG pie chart if PGs are doing some non
critical work. It is a "mid" blue that works quite well in both, light
and dark theme.
The wrench symbol can be a bit thin as it is even smaller than the main
icon. Maybe the `cog` icon works better? But no hard feelings on either
from my side.
The cog wheel and the blue would result in the following CSS class:
.x-tree-icon-custom.ha-maintenance:after,
.x-grid-icon-custom.ha-maintenance:after {
content: "\f013";
color: #3892d4;
}
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-13 9:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 8:07 Dominik Csapak
2024-05-31 10:07 ` Dominik Csapak
2024-11-12 19:49 ` Thomas Lamprecht
2024-11-13 9:16 ` Aaron Lauterer [this message]
2024-11-13 10:49 ` Thomas Lamprecht
2024-11-13 10:53 ` Dominik Csapak
2024-11-13 11:20 ` Thomas Lamprecht
2024-11-13 11:39 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bac79ec-7598-4c8d-952f-a394044a08cb@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox