From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied-esries: [PATCH installer v2 0/6] fix #4872: properly timeout `traceroute` command in country detection
Date: Fri, 23 Feb 2024 16:17:47 +0100 [thread overview]
Message-ID: <1b710d73-2e42-4fab-b65a-b042f8fa7d3f@proxmox.com> (raw)
In-Reply-To: <20240213151405.1282639-1-c.heiss@proxmox.com>
Am 13/02/2024 um 16:13 schrieb Christoph Heiss:
> For all the details, see patch #6.
>
> TL;DR: SIGALRM does not interrupt line reading using <>, causing the
> installer to hang on country detection. Fix it by using
> Proxmox::Sys::Command::run_command(), which properly interacts with
> SIGALRM.
>
> Patch #1 is a rather mundane fix for some niche cases, #2 is a small
> refactoring as proposed by Thomas and #3 might warrant some more
> thought. #4 & #5 are preparatory and to not alter existing behaviour.
>
> v1: https://lists.proxmox.com/pipermail/pve-devel/2024-February/061677.html
>
> Changes since v1:
> * new patches #2 (refactoring) and #3 (EINTR handling)
> * introduce CMD_FINISHED constant for run_command()
> * added function documentation
>
> Christoph Heiss (6):
> low-level: initialize UI backend for 'dump-env' subcommand too
> sys: command: factor out kill() + waitpid() from run_command()
> sys: command: handle EINTR in run_command()
> sys: command: allow terminating the process early from log subroutine
> sys: command: add option to not print process output to stdout
> fix #4872: run env: use run_command() for country detection
>
> Proxmox/Install/RunEnv.pm | 22 +++++-----
> Proxmox/Sys/Command.pm | 85 ++++++++++++++++++++++++++++++++-----
> proxmox-low-level-installer | 1 +
> test/Makefile | 5 ++-
> test/run-command.pl | 46 ++++++++++++++++++++
> 5 files changed, 137 insertions(+), 22 deletions(-)
> create mode 100755 test/run-command.pl
>
> --
> 2.43.0
>
applied series, with a small follow-up to that tries to make wait_for_process
a bit more forgiving towards processes that need a bit of time for a graceful
exit, thanks!
prev parent reply other threads:[~2024-02-23 15:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 15:13 [pve-devel] " Christoph Heiss
2024-02-13 15:13 ` [pve-devel] [PATCH installer v2 1/6] low-level: initialize UI backend for 'dump-env' subcommand too Christoph Heiss
2024-02-13 15:13 ` [pve-devel] [PATCH installer v2 2/6] sys: command: factor out kill() + waitpid() from run_command() Christoph Heiss
2024-02-13 15:14 ` [pve-devel] [PATCH installer v2 3/6] sys: command: handle EINTR in run_command() Christoph Heiss
2024-02-13 15:14 ` [pve-devel] [PATCH installer v2 4/6] sys: command: allow terminating the process early from log subroutine Christoph Heiss
2024-02-13 15:14 ` [pve-devel] [PATCH installer v2 5/6] sys: command: add option to not print process output to stdout Christoph Heiss
2024-02-13 15:14 ` [pve-devel] [PATCH installer v2 6/6] fix #4872: run env: use run_command() for country detection Christoph Heiss
2024-02-23 15:17 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b710d73-2e42-4fab-b65a-b042f8fa7d3f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox