public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Alwin Antreich <alwin@antreich.com>
Subject: Re: [pve-devel] [PATCH storage] rbd: add support for erasure coded ec pools
Date: Thu, 27 Jan 2022 12:27:06 +0100	[thread overview]
Message-ID: <1ae1d772-c466-5694-cf77-4018aedddafc@proxmox.com> (raw)
In-Reply-To: <3dbb90bb8bfec2db7a08965c0301480f@antreich.com>

On 1/26/22 19:30, Alwin Antreich wrote:
> Hello Aaron,
> 
> nice to see EC pools are coming. ;)
> 
> January 26, 2022 5:07 PM, "Aaron Lauterer" <a.lauterer@proxmox.com> wrote:
> 
>> The first step is to allocate rbd images correctly.
>>
>> The metadata objects still need to be stored in a replicated pool, but
>> by providing the --data-pool parameter on image creation, we can place
>> the data objects on the erasure coded (EC) pool.
> 
> AFAICR, there is an undocumented location for a ceph.conf,
> `/etc/pve/priv/ceph/<storage-name>.conf`.

Thanks for the hint, as I wasn't aware of it. It will not be considered for PVE managed Ceph though, so not really an option here.[0]

[0] https://git.proxmox.com/?p=pve-storage.git;a=blob;f=PVE/CephConfig.pm;h=c388f025b409c660913c082763765dda0fba2c6c;hb=HEAD#l192

> 
> The config should have the following content.
> ```
> [client.admin_ec]
> rbd default data pool = ceph_pool_ec
> ````
> Then rbd will use the data pool. This should probably work for all storage operations.
> 
> Newer ceph versions should also work with the config db option.
> ```
> ceph config set client.xxx rbd_default_data_pool ceph_pool_e> ```

What these approaches do have in common, is that we spread the config over multiple places and cannot set different data pools for different storages.

I rather keep the data pool stored in our storage.cfg and apply the parameter where needed. From what I can tell, I missed the image clone in this patch, where the data-pool also needs to be applied.
But this way we have the settings for that storage in one place we control and are also able to have different EC pools for different storages. Not that I expect it to happen a lot in practice, but you never know.

> 
> Cheers,
> Alwin
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 




  reply	other threads:[~2022-01-27 11:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-26 16:07 Aaron Lauterer
2022-01-26 18:30 ` Alwin Antreich
2022-01-27 11:27   ` Aaron Lauterer [this message]
2022-01-27 15:41   ` Alwin Antreich
2022-01-27 16:28     ` Aaron Lauterer
2022-01-28  5:50       ` Thomas Lamprecht
2022-01-28  9:22       ` Alwin Antreich
2022-01-28  9:50         ` Aaron Lauterer
2022-01-28 10:54         ` Alwin Antreich
2022-01-28 11:21           ` Aaron Lauterer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ae1d772-c466-5694-cf77-4018aedddafc@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=alwin@antreich.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal