From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] drive: volume in-use check: fix fallback path comparison
Date: Sun, 18 Apr 2021 17:30:00 +0200 [thread overview]
Message-ID: <1aa9184c-9e53-f62a-68f3-256c69a79eba@proxmox.com> (raw)
In-Reply-To: <20210415101057.2836-1-f.ebner@proxmox.com>
On 15.04.21 12:10, Fabian Ebner wrote:
> When checking whether a volume is still referenced by a snapshot, the volid
> itself is first checked. When the volid is different, we fall back to comparing
> the path.
>
> As the first value to be compared is a volume's path, the second value better be
> a volume's path too, and not a snapshot's path.
>
> See also 77019edfe0c190c949cdc0b0e3b4ad2ca37313b3 for historical context.
>
> The error that led me here:
> * had a VM with ZFS over iSCSI storage with an exsiting snapshot
> * add new unused drive
> * try to remove the unsued drive
> * fails, because ZFS (not Pool!) Plugin does not support snapshot paths.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/QemuServer/Drive.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
> index 01ea8d7..9016a43 100644
> --- a/PVE/QemuServer/Drive.pm
> +++ b/PVE/QemuServer/Drive.pm
> @@ -590,7 +590,7 @@ sub is_volume_in_use {
> next if !$storeid;
> my $scfg = PVE::Storage::storage_config($storecfg, $storeid, 1);
> next if !$scfg;
> - return 1 if $path eq PVE::Storage::path($storecfg, $drive->{file}, $snapname);
> + return 1 if $path eq PVE::Storage::path($storecfg, $drive->{file});
makes the whole $snapname param of that closure unused, which seems OK as $cref
holds the actual info, FWICT after a quick look.
So, if that patch is sound it should probably remove the $snapname from $scan_config
closure too.
> }
> }
> }
>
next prev parent reply other threads:[~2021-04-18 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 10:10 Fabian Ebner
2021-04-18 15:30 ` Thomas Lamprecht [this message]
2021-04-18 16:00 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aa9184c-9e53-f62a-68f3-256c69a79eba@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox