public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH container] snapshot creation: only check volumes for fsfreeze
Date: Mon, 23 Nov 2020 13:09:40 +0100	[thread overview]
Message-ID: <1a855b57-beba-872b-34fe-0d302cd6d27a@proxmox.com> (raw)
In-Reply-To: <20201123101229.18308-1-s.ivanov@proxmox.com>

On 23.11.20 11:12, Stoiko Ivanov wrote:
> fix #3161
> 
> When considering mountpoints for running 'fsfreeze' before snapshot creation,
> commit 8463099d99273561c46398bf02206b4d9d431bc5 did not only consider
> volumes created by our storage-stack, but also bindmounts and devmounts
> (directly mounting a blockdevice).
> 
> This led to PVE::Storage::parse_volume_id failing on those mountpoints.
> 
> Since the fsfreeze call is best-effort and only run for specific
> storageplugins, we can simply skip non-volume mountpoints, when gathering
> the list of volumes to call fsfreeze on.
> 
> Tested with a container with a bindmount.
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> Sorry for that - will test my container patches with a more complete container
> config from now on :/
> 
>  src/PVE/LXC/Config.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied, with Dominic's T-b tag thanks!

Please prefix the `fix #ID:` in the commit subject and try to keep lines shorter
than 70 characters[0]

[0]: https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages





      parent reply	other threads:[~2020-11-23 12:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-23 10:12 [pve-devel] " Stoiko Ivanov
2020-11-23 10:25 ` Dominic Jäger
2020-11-23 12:09 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a855b57-beba-872b-34fe-0d302cd6d27a@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal