From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, aderumier@odiso.com
Subject: Re: [pve-devel] [PATCH v5 qemu-server 7/9] api2: qemu : don't display cloudinit value
Date: Wed, 8 Jun 2022 12:13:59 +0200 [thread overview]
Message-ID: <199d2486-e9ba-f943-bea3-0f57c4f6c753@proxmox.com> (raw)
In-Reply-To: <20220516160719.3818057-8-aderumier@odiso.com>
Am 16.05.22 um 18:07 schrieb Alexandre Derumier:
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
> PVE/API2/Qemu.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index 1d5b66f..57a75fc 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -1227,6 +1227,7 @@ __PACKAGE__->register_method({
> $conf = PVE::QemuConfig->load_current_config($param->{vmid}, $param->{current});
It'd be a bit nicer to have load_current_config() not return the
cloudinit section. And because the implementation in AbstractConfig.pm
shouldn't need to know about the cloudinit section, I think we should
override load_current_config() in QemuConfig.pm (calling the parent
method and removing the cloudinit section there).
> }
> $conf->{cipassword} = '**********' if $conf->{cipassword};
> + delete $conf->{cloudinit};
> return $conf;
>
> }});
next prev parent reply other threads:[~2022-06-08 10:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 16:07 [pve-devel] [PATCH v5 qemu-server 0/9] cloudinit pending behaviour change Alexandre Derumier
2022-05-16 16:07 ` [pve-devel] [PATCH v5 qemu-server 1/9] cloudinit: add cloudinit section for current generated config Alexandre Derumier
2022-05-16 16:07 ` [pve-devel] [PATCH v5 qemu-server 2/9] generate cloudinit drive on offline plug Alexandre Derumier
2022-05-16 16:07 ` [pve-devel] [PATCH v5 qemu-server 3/9] cloudinit: make cloudnit options fastplug Alexandre Derumier
2022-05-16 16:07 ` [pve-devel] [PATCH v5 qemu-server 4/9] api2: add cloudinit config api Alexandre Derumier
2022-05-16 16:07 ` [pve-devel] [PATCH v5 qemu-server 5/9] api2: add cloudinit_update Alexandre Derumier
2022-05-16 16:07 ` [pve-devel] [PATCH v5 qemu-server 6/9] add cloudinit hotplug Alexandre Derumier
2022-05-16 16:07 ` [pve-devel] [PATCH v5 qemu-server 7/9] api2: qemu : don't display cloudinit value Alexandre Derumier
2022-06-08 10:13 ` Fabian Ebner [this message]
2022-05-16 16:07 ` [pve-devel] [PATCH v5 qemu-server 8/9] vzdump : skip special:cloudinit section Alexandre Derumier
2022-05-16 16:07 ` [pve-devel] [PATCH v5 qemu-server 9/9] migration: test targetnode min version for cloudinit section Alexandre Derumier
2022-06-08 10:14 ` Fabian Ebner
2022-06-08 10:14 ` [pve-devel] [PATCH v5 qemu-server 0/9] cloudinit pending behaviour change Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199d2486-e9ba-f943-bea3-0f57c4f6c753@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox