public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable
@ 2023-11-29 13:21 Maximiliano Sandoval
  2023-12-06  9:46 ` Dominik Csapak
  0 siblings, 1 reply; 12+ messages in thread
From: Maximiliano Sandoval @ 2023-11-29 13:21 UTC (permalink / raw)
  To: pve-devel

Note that ACME is already in 3 translatable strings, a similar remark
applies to N/A which is already translated in many languages.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/node/DNSView.js                   | 2 +-
 src/panel/ACMEDomains.js              | 2 +-
 src/panel/DiskList.js                 | 6 +++---
 src/window/NotificationMatcherEdit.js | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/node/DNSView.js b/src/node/DNSView.js
index 4782f9c..d2a784f 100644
--- a/src/node/DNSView.js
+++ b/src/node/DNSView.js
@@ -21,7 +21,7 @@ Ext.define('Proxmox.node.DNSView', {
 	    run_editor: run_editor,
 	    rows: {
 		search: {
-		    header: 'Search domain',
+		    header: gettext('Search domain'),
 		    required: true,
 		    renderer: Ext.htmlEncode,
 		},
diff --git a/src/panel/ACMEDomains.js b/src/panel/ACMEDomains.js
index a7fb088..9e2e34b 100644
--- a/src/panel/ACMEDomains.js
+++ b/src/panel/ACMEDomains.js
@@ -10,7 +10,7 @@ Ext.define('Proxmox.panel.ACMEDomains', {
     mixins: ['Proxmox.Mixin.CBind'],
 
     margin: '10 0 0 0',
-    title: 'ACME',
+    title: gettext('ACME'),
 
     emptyText: gettext('No Domains configured'),
 
diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js
index 4808f5c..dc10ac5 100644
--- a/src/panel/DiskList.js
+++ b/src/panel/DiskList.js
@@ -325,14 +325,14 @@ Ext.define('Proxmox.DiskList', {
 	    dataIndex: 'status',
 	},
 	{
-	    header: 'Mounted',
+	    header: gettext('Mounted'),
 	    width: 60,
 	    align: 'right',
 	    renderer: Proxmox.Utils.format_boolean,
 	    dataIndex: 'mounted',
 	},
 	{
-	    header: 'Wearout',
+	    header: gettext('Wearout'),
 	    width: 90,
 	    sortable: true,
 	    align: 'right',
@@ -341,7 +341,7 @@ Ext.define('Proxmox.DiskList', {
 		if (Ext.isNumeric(value)) {
 		    return (100 - value).toString() + '%';
 		}
-		return 'N/A';
+		return gettext('N/A');
 	    },
 	},
     ],
diff --git a/src/window/NotificationMatcherEdit.js b/src/window/NotificationMatcherEdit.js
index f88576a..e717ad7 100644
--- a/src/window/NotificationMatcherEdit.js
+++ b/src/window/NotificationMatcherEdit.js
@@ -1025,7 +1025,7 @@ Ext.define('Proxmox.panel.NotificationMatchRuleSettings', {
 	    ],
 	},
 	{
-	    fieldLabel: 'Match Type',
+	    fieldLabel: gettext('Match Type'),
 	    xtype: 'proxmoxKVComboBox',
 	    reference: 'type',
 	    isFormField: false,
-- 
2.39.2





^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2023-12-06 15:55 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-29 13:21 [pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable Maximiliano Sandoval
2023-12-06  9:46 ` Dominik Csapak
2023-12-06 10:21   ` Maximiliano Sandoval
2023-12-06 11:00     ` Dominik Csapak
2023-12-06 11:13       ` Maximiliano Sandoval
2023-12-06 11:19         ` Dominik Csapak
2023-12-06 11:20       ` Fiona Ebner
2023-12-06 11:22         ` Dominik Csapak
2023-12-06 14:04       ` Maximiliano Sandoval
2023-12-06 14:26         ` Dominik Csapak
2023-12-06 15:54           ` Thomas Lamprecht
2023-12-06 15:16         ` Dietmar Maurer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal