From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH manager] ui: ceph: osd: set default icon for other crush types
Date: Wed, 15 Feb 2023 15:16:55 +0100 (CET) [thread overview]
Message-ID: <197995403.9367.1676470615133@webmail.proxmox.com> (raw)
In-Reply-To: <ed101e88-7d0a-ff15-fafb-723d07a0489c@proxmox.com>
> On 02/15/2023 3:08 PM CET Dominik Csapak <d.csapak@proxmox.com> wrote:
>
>
> applied, with a short follow up that moves the icon inside the interpolated string
> (it's shorter and still readable)
>
> should we maybe look into adding specific icons for pre-generated types?
> or is that a niche feature for our users anyway?
I thought about it and tried it at first. But honestly, I think that a generic icon should work in most situations to guide the eye better where hierarchy levels are.
Overall, I think this is a niche use case.
prev parent reply other threads:[~2023-02-15 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 9:29 [pve-devel] " Aaron Lauterer
2022-12-01 12:23 ` Aaron Lauterer
2023-02-08 9:56 ` Aaron Lauterer
2023-02-15 14:08 ` [pve-devel] applied: " Dominik Csapak
2023-02-15 14:16 ` Aaron Lauterer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=197995403.9367.1676470615133@webmail.proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox