From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] checking output of storage plugin API - volume_rollback_is_possible(..., blockers)
Date: Thu, 15 May 2025 11:16:43 +0200 (CEST) [thread overview]
Message-ID: <1975340184.15398.1747300603697@webmail.proxmox.com> (raw)
In-Reply-To: <mailman.409.1747226995.394.pve-devel@lists.proxmox.com>
> Andrei Perapiolkin via pve-devel <pve-devel@lists.proxmox.com> hat am 14.05.2025 14:44 CEST geschrieben:
> Hi,
>
> I'm trying to test specific aspects of the storage plugin API,
> and I'm not sure how to verify whether my function
> volume_rollback_is_possible
> correctly sets up the blockers list.
>
> I've checked REST API documentation:
> https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/qemu/{vmid}/snapshot/{snapname}/rollback
>
> CLI tool:
> qm rollback
>
> But I couldn't find where the list of blockers is returned or printed.
the $blockers parameter is currently only passed in replication contexts:
https://git.proxmox.com/?p=pve-guest-common.git;a=blob;f=src/PVE/AbstractConfig.pm;h=3d4fcbbf98553b1f4edc8f59307daae1cf1b8a2f;hb=HEAD#l1051
the expected behaviour is to
- fill $blockers with the snapshot names preventing the rollback, if there are any
- to die with an error message if rollback is not possible
the caller can then decide if they want to pass a $blockers reference, and upon
catching the error, inspect it to give a nicer error message.
you can see how the 'zfs' plugin handles it (the only one supporting replication
at the moment):
https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage/ZFSPoolPlugin.pm;h=26fb0a4237e5c1013ebfa85ca2cc072c57d2c36f;hb=HEAD#l502
and model your implementation after its behaviour (of course, whether rolling
back is limited to the most recent snapshot like it is with ZFS is up to you
and your storage ;))
> Are there any posts, guides, or documentation on how to test blockers or
> other return values from storage plugins?
out of interest - is your plugin publicly available?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-05-15 9:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 12:44 Andrei Perapiolkin via pve-devel
2025-05-15 9:16 ` Fabian Grünbichler [this message]
2025-05-15 11:23 ` Andrei Perapiolkin via pve-devel
[not found] ` <d32e8977-da91-427e-aa15-4937f9894fe3@open-e.com>
2025-05-15 12:28 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1975340184.15398.1747300603697@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox