public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Matthias Heiserer <m.heiserer@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/2] GUI: efi disk: use correct version with aarch64
Date: Wed, 18 Jan 2023 15:07:15 +0100	[thread overview]
Message-ID: <197294f6-2746-37bc-4b88-8b09679b4ba0@proxmox.com> (raw)
In-Reply-To: <20230117121723.65246-1-m.heiserer@proxmox.com>

for subject: s/GUI/ui/ to better match the predominantly used one.

Am 17/01/2023 um 13:17 schrieb Matthias Heiserer:
> Sets the EFI version to 2m when arch=aarch64.
> 
> When the VM has arch=aarch64, creating an EFI disk failed with
> "Can't use an undefined value as an ARRAY reference at /usr/share/perl5/PVE/QemuServer.pm line 3382. (500)"
> 
> That's because we only have EFI 2m available for aarch64.
> 
> Reported in the forum: https://forum.proxmox.com/threads/121160/
> 

If we go this route I'd also enforce using the correct one when changing
or creating VMs via the API.

Two possible alternatives:
- auto-select the existing one in the backend; drawback: if we ever add
  another size for the AAVMF image we need to take extra/special care to
  avoid breaking old systems.

- build also an AAVMF image with 4MB, but one would need to check if this
  is really possible in the first place or if there are other drawbacks.




  parent reply	other threads:[~2023-01-18 14:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 12:17 Matthias Heiserer
2023-01-17 12:17 ` [pve-devel] [PATCH manager 2/2] GUI: efi disk: cleanup - var to const Matthias Heiserer
2023-01-18 14:03   ` Thomas Lamprecht
2023-01-20 11:16     ` Matthias Heiserer
2023-01-20 13:59       ` Thomas Lamprecht
2023-01-18 14:07 ` Thomas Lamprecht [this message]
2023-01-20 12:56   ` [pve-devel] [PATCH manager 1/2] GUI: efi disk: use correct version with aarch64 Matthias Heiserer
2023-01-20 13:17     ` Thomas Lamprecht
2023-01-20 14:18       ` Matthias Heiserer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=197294f6-2746-37bc-4b88-8b09679b4ba0@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.heiserer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal