Re: [pve-devel] [RFC firewall] api: Add optional parameters `since` and `until` for timestamp filter

[Christian Ebner <c.ebner@proxmox.com>]

Okay, I will take your comments into consideration, thx!

> On 05.01.2023 14:59 CET Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:
> 
>  
> Am 05/01/2023 um 14:51 schrieb Fiona Ebner:
> >> +	my($count, $lines) = PVE::Tools::dump_fw_logfile("/var/log/pve-firewall.log",
> >> +		$param->{start}, $param->{limit}, undef, $param->{since}, $param->{until});
> > Style nit: please use 1 line for each parameter if it gets too long [1]
> > 
> 
> In general we try to adhere to rustfmt style, at least in spirit as not everything 
> can be mapped to perl. That format has an intermediate step between one arg per line
> namely something like:
> 
>     PVE::Tools::foo(
>         $bar, $baz, $very_long_argument_bla_bla)
> 
> Here, that might still work out if we pull out the $param stuff first, e.g.::
> 
>     my ($start, $limit, $since, $until) = param->@{qw(start limit since until)};
> 
>     PVE::Tools::dump_fw_logfile(
>         "/var/log/pve-firewall.log", $start, $limit, undef, $since, $until)