From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Thomas Skinner <thomas@atskinner.net>
Subject: Re: [pve-devel] [PATCH http-server 1/1] fix #5699: pveproxy: add library methods for real IP support
Date: Mon, 25 Nov 2024 12:31:16 +0100 (CET) [thread overview]
Message-ID: <1918265431.10020.1732534276567@webmail.proxmox.com> (raw)
In-Reply-To: <72220c9e-4e33-416b-85e5-4c73cb7c6ad6@proxmox.com>
> Thomas Lamprecht <t.lamprecht@proxmox.com> hat am 25.11.2024 12:17 CET geschrieben:
>
>
> Am 25.11.24 um 10:05 schrieb Fabian Grünbichler:
> > yeah, we could switch to the new format *only* if the header option is set?
> > as else, the two IPs are identical anyway, so logging the same one twice
> > while breaking the format provides no benefit?
> >
> > and then maybe with 9.0 switch the format unconditionally, so that
> > parsers/fail2ban configs only need to handle one of them going forward..
>
> Sounds fine to me. Albeit for some this still might break, if they already
> use a reverse proxy now – but these people at least could not have any
> (working) fail2ban, as they just would have banned the IP of their reverse
> proxy, so it should be fine I think.
it would still require enabling the new feature on the pveproxy side (that's what I meant with "header option", not that the default header is set on the HTTP request), so it's completely opt-in?
> btw., and sorry if I just missed this on reading, how do others log this?
> I.e., is there any somewhat common format and does this patch already
> adheres to that format?
that would indeed be nice to know! :)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-25 11:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 0:30 [pve-devel] [PATCH SERIES manager/http-server/docs] fix #5699: add support for real IP Thomas Skinner
2024-09-10 0:30 ` [pve-devel] [PATCH docs 1/1] fix #5699: pveproxy: add docs for real IP support Thomas Skinner
2024-11-13 11:36 ` Fabian Grünbichler
2024-09-10 0:30 ` [pve-devel] [PATCH http-server 1/1] fix #5699: pveproxy: add library methods " Thomas Skinner
2024-11-13 11:34 ` Fabian Grünbichler
2024-11-24 23:49 ` Thomas Skinner
2024-11-25 8:31 ` Thomas Lamprecht
2024-11-25 9:05 ` Fabian Grünbichler
2024-11-25 11:17 ` Thomas Lamprecht
2024-11-25 11:31 ` Fabian Grünbichler [this message]
2024-11-25 23:41 ` Thomas Skinner
2024-09-10 0:30 ` [pve-devel] [PATCH manager 1/1] fix #5699: pveproxy: add settings " Thomas Skinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1918265431.10020.1732534276567@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
--cc=thomas@atskinner.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox