From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [RFC manager] triggers: add path-based trigger interest
Date: Tue, 12 Nov 2024 11:28:12 +0100 (CET) [thread overview]
Message-ID: <1911594801.2268.1731407292877@webmail.proxmox.com> (raw)
In-Reply-To: <dac8ca00-78fa-4d5f-a364-6b5b84c704d1@proxmox.com>
> Thomas Lamprecht <t.lamprecht@proxmox.com> hat am 12.11.2024 10:52 CET geschrieben:
>
>
> Am 12.11.24 um 10:11 schrieb Fabian Grünbichler:
> > the HA case could also switch over to this approach, if we want to
> > reload HA for all PVE perl modules.. if we only want it for a subset,
> > then yes, the/an explicit trigger is better :)
>
> [...]
>
> > see above - the question is whether we want an explicit list of packages
> > that trigger HA (and risk that it runs out of sync with the modules the
> > HA actually uses), or whether we want to treat HA like the pve-manager
> > services, and just let it reload on any perl module changes that *could*
> > affect it..
> >
> > if desired, I can send a similar patch for pve-ha-manager as well.
>
> Yes, that's an option, but I was wording my reply from yesterday so vague
> by choice (or well, being to lazy to decide so late) to not go in a
> explicit direction, as while it would be nice to have this covered in a
> general fashion, more frequently restarting HA is also something that
> can increase problem frequency. But, tbh., it should not be that much and
> it has to work anyway, so can be fine by me.
>
> Still needs the trigger from pmxcfs I guess? As IMO we should not depend
> that it will always ship in the same package as some perl code that falls
> under your generic trigger.
do we need a trigger for pmxcfs itself? if it gets updated, it restarts itself anyway, and nothing else directly depends on it? the perl bindings to talk to pmxcfs (PVE::IPCC and PVE::Cluster) are covered by the generic path-based trigger for /usr/share/perl5/PVE , so anything using that to talk to it should just express interest on that path..
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-12 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 11:43 [pve-devel] " Fabian Grünbichler
2024-11-11 17:44 ` [pve-devel] applied: " Thomas Lamprecht
2024-11-12 9:11 ` Fabian Grünbichler
2024-11-12 9:52 ` Thomas Lamprecht
2024-11-12 10:28 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1911594801.2268.1731407292877@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox