public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager master stable-7] pve7to8: Fix Fedora 38 systemd unified cgroupv2 check
Date: Wed, 27 Sep 2023 08:58:44 +0200 (CEST)	[thread overview]
Message-ID: <1902644527.4866.1695797924894@webmail.proxmox.com> (raw)
In-Reply-To: <20230828075414.9729-1-c.ebner@proxmox.com>

Ping, see also https://forum.proxmox.com/threads/128721/

> On 28.08.2023 09:54 CEST Christian Ebner <c.ebner@proxmox.com> wrote:
> 
>  
> For Fedora 38 the systemd shared object files used to check the systemd
> version are located at /usr/lib64/systemd or /usr/lib/systemd.
> Therefore, include /usr/lib64/systemd in the list of directories to
> check.
> 
> Further, Fedora 38 adds a fc38 postfix to the filename, so expand the
> regex to cover that as well.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> 
> Reported by users via the forum:
> https://forum.proxmox.com/threads/128721/#post-584456
> 
>  PVE/CLI/pve7to8.pm | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm
> index ff8e6045..3947b260 100644
> --- a/PVE/CLI/pve7to8.pm
> +++ b/PVE/CLI/pve7to8.pm
> @@ -1022,12 +1022,18 @@ sub check_containers_cgroup_compat {
>  	my $get_systemd_version = sub {
>  	    my ($self) = @_;
>  
> +	    my @dirs = (
> +		'/lib/systemd',
> +		'/usr/lib/systemd',
> +		'/usr/lib/x86_64-linux-gnu/systemd',
> +		'/usr/lib64/systemd'
> +	    );
>  	    my $libsd;
> -	    for my $dir ('/lib/systemd', '/usr/lib/systemd', '/usr/lib/x86_64-linux-gnu/systemd') {
> +	    for my $dir (@dirs) {
>  		$libsd = PVE::Tools::dir_glob_regex($dir, "libsystemd-shared-.+\.so");
>  		last if defined($libsd);
>  	    }
> -	    if (defined($libsd) && $libsd =~ /libsystemd-shared-(\d+)(\.\d-\d)?\.so/) {
> +	    if (defined($libsd) && $libsd =~ /libsystemd-shared-(\d+)(\.\d-\d)?(\.fc\d\d)?\.so/) {
>  		return $1;
>  	    }
>  
> -- 
> 2.39.2




  reply	other threads:[~2023-09-27  6:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-28  7:54 Christian Ebner
2023-09-27  6:58 ` Christian Ebner [this message]
2023-09-27 17:08 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1902644527.4866.1695797924894@webmail.proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal